Add PeriodicWaveConstraints dictionary

Add PeriodicWaveConstraints dictionary

When support for disabling normalization for createPeriodicWave was
added, the corresponding PeriodicWaveConstraints dictionary was not.
Add it now.

No change in behavior.

WebAudio spec: http://webaudio.github.io/web-audio-api/#periodicwaveconstraints

BUG=608934
TEST=none

Committed: https://crrev.com/eb671f128cb93ca42e255761b7b0b7bb0b7c0055
Cr-Commit-Position: refs/heads/master@{#391924}

[Raymond Toy, 2016-05-03 23:29:13]

Description was changed from

==========
Add PeriodicWaveConstraints dictionary

When support for disabling normalization for createPeriodicWave was
added, the corresponding PeriodicWaveConstraints dictionary was not.
Add it now.

No change in behavior.

BUG=608934
TEST=none
==========

to

==========
Add PeriodicWaveConstraints dictionary

When support for disabling normalization for createPeriodicWave was
added, the corresponding PeriodicWaveConstraints dictionary was not.
Add it now.

No change in behavior.

WebAudio spec: http://webaudio.github.io/web-audio-api/#periodicwaveconstraints

BUG=608934
TEST=none
==========

[Raymond Toy, 2016-05-04 18:37:28]

rtoy@chromium.org changed reviewers:
+ hongchan@chromium.org

[Raymond Toy, 2016-05-04 18:37:29]

PTAL

[hongchan, 2016-05-04 18:41:23]

lgtm

[Raymond Toy, 2016-05-04 18:45:36]

rtoy@chromium.org changed reviewers:
+ rbyers@chromium.org

[Raymond Toy, 2016-05-04 18:45:37]

rbyers: PTAL as API Owner.  We're just adding the missing
PeriodicWaveConstraints dictionary.

[Rick Byers, 2016-05-05 14:13:39]

Thanks for the clean-up, and I agree there's no web-exposed behavior change here
(though hopefully that'll change in the future:
https://github.com/heycam/webidl/issues/107).

LGTM with nit

https://codereview.chromium.org/1948653003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/webaudio/AbstractAudioContext.cpp
(right):

https://codereview.chromium.org/1948653003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webaudio/AbstractAudioContext.cpp:601: if
(options.hasDisableNormalization())
nit: since this is a required dictionary member (with a default value) I believe
you can simplify this (and avoid specifying the default value in both the IDL
and CPP) with just:

bool isNormalizationDisabled = options.disableNormalization();

[Raymond Toy, 2016-05-05 17:11:46]

https://codereview.chromium.org/1948653003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/webaudio/AbstractAudioContext.cpp
(right):

https://codereview.chromium.org/1948653003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webaudio/AbstractAudioContext.cpp:601: if
(options.hasDisableNormalization())
On 2016/05/05 14:13:39, Rick Byers wrote:
> nit: since this is a required dictionary member (with a default value) I
believe
> you can simplify this (and avoid specifying the default value in both the IDL
> and CPP) with just:
> 
> bool isNormalizationDisabled = options.disableNormalization();

Done.  Removed the default value from the IDL was well.

[Raymond Toy, 2016-05-05 17:12:13]

The CQ bit was checked by rtoy@chromium.org

[Raymond Toy, 2016-05-05 17:12:13]

The patchset sent to the CQ was uploaded after l-g-t-m from rbyers@chromium.org,
hongchan@chromium.org
Link to the patchset: https://codereview.chromium.org/1948653003/#ps60001
(title: "Remove default value from dictionary")

[commit-bot: I haz the power, 2016-05-05 17:12:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1948653003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1948653003/60001

[Rick Byers, 2016-05-05 17:57:20]

On 2016/05/05 17:11:46, Raymond Toy wrote:
>
https://codereview.chromium.org/1948653003/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/modules/webaudio/AbstractAudioContext.cpp
> (right):
> 
>
https://codereview.chromium.org/1948653003/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/modules/webaudio/AbstractAudioContext.cpp:601: if
> (options.hasDisableNormalization())
> On 2016/05/05 14:13:39, Rick Byers wrote:
> > nit: since this is a required dictionary member (with a default value) I
> believe
> > you can simplify this (and avoid specifying the default value in both the
IDL
> > and CPP) with just:
> > 
> > bool isNormalizationDisabled = options.disableNormalization();
> 
> Done.  Removed the default value from the IDL was well.

Does that work?  I thought the default value was necessary to ensure the option
was always present (at least what's what the WebIDL spec says:
http://heycam.github.io/webidl/#es-dictionary).

[commit-bot: I haz the power, 2016-05-05 19:02:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-05 19:02:16]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Raymond Toy, 2016-05-05 20:20:38]

On 2016/05/05 19:02:16, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

The check for hasDisableNormalization seems to be required.  

I ran this CL in a debug build and for some reason calling
options.disableNormalization() causes a crash.  gdb says

(gdb) p options.disableNormalization
$140 = {bool (const blink::PeriodicWaveConstraints * const)} 0x7fc186f59800
<blink::CanvasContextCreationAttributes::alpha() const>

I don't really understand how a PeriodicWaveConstraints object has the
disableNormalization method pointing to the
CanvasContextCreationAttributes::alpha method.  The crash is coming from the
alpha() method.  (At least for the oscillator-basics.html test that calls
createPeriodicWave without the PeriodicWaveConstraints option given.

Changing the code to include the check makes all of the tests pass.

[Raymond Toy, 2016-05-05 20:27:27]

The CQ bit was checked by rtoy@chromium.org

[Raymond Toy, 2016-05-05 20:27:28]

The patchset sent to the CQ was uploaded after l-g-t-m from rbyers@chromium.org,
hongchan@chromium.org
Link to the patchset: https://codereview.chromium.org/1948653003/#ps80001
(title: "Fix test failures")

[commit-bot: I haz the power, 2016-05-05 20:28:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1948653003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1948653003/80001

[commit-bot: I haz the power, 2016-05-05 22:20:29]

Description was changed from

==========
Add PeriodicWaveConstraints dictionary

When support for disabling normalization for createPeriodicWave was
added, the corresponding PeriodicWaveConstraints dictionary was not.
Add it now.

No change in behavior.

WebAudio spec: http://webaudio.github.io/web-audio-api/#periodicwaveconstraints

BUG=608934
TEST=none
==========

to

==========
Add PeriodicWaveConstraints dictionary

When support for disabling normalization for createPeriodicWave was
added, the corresponding PeriodicWaveConstraints dictionary was not.
Add it now.

No change in behavior.

WebAudio spec: http://webaudio.github.io/web-audio-api/#periodicwaveconstraints

BUG=608934
TEST=none
==========

[commit-bot: I haz the power, 2016-05-05 22:20:30]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-05-05 22:22:32]

Description was changed from

==========
Add PeriodicWaveConstraints dictionary

When support for disabling normalization for createPeriodicWave was
added, the corresponding PeriodicWaveConstraints dictionary was not.
Add it now.

No change in behavior.

WebAudio spec: http://webaudio.github.io/web-audio-api/#periodicwaveconstraints

BUG=608934
TEST=none
==========

to

==========
Add PeriodicWaveConstraints dictionary

When support for disabling normalization for createPeriodicWave was
added, the corresponding PeriodicWaveConstraints dictionary was not.
Add it now.

No change in behavior.

WebAudio spec: http://webaudio.github.io/web-audio-api/#periodicwaveconstraints

BUG=608934
TEST=none

Committed: https://crrev.com/eb671f128cb93ca42e255761b7b0b7bb0b7c0055
Cr-Commit-Position: refs/heads/master@{#391924}
==========

[commit-bot: I haz the power, 2016-05-05 22:22:33]

Patchset 5 (id:??) landed as
https://crrev.com/eb671f128cb93ca42e255761b7b0b7bb0b7c0055
Cr-Commit-Position: refs/heads/master@{#391924}