Add PeriodicWaveConstraints dictionary

third_party/WebKit/Source/modules/webaudio/AbstractAudioContext.cpp

 /*
  * Copyright (C) 2010, Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1.  Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 42 matching lines @@
 #include "modules/webaudio/IIRFilterNode.h"
 #include "modules/webaudio/MediaElementAudioSourceNode.h"
 #include "modules/webaudio/MediaStreamAudioDestinationNode.h"
 #include "modules/webaudio/MediaStreamAudioSourceNode.h"
 #include "modules/webaudio/OfflineAudioCompletionEvent.h"
 #include "modules/webaudio/OfflineAudioContext.h"
 #include "modules/webaudio/OfflineAudioDestinationNode.h"
 #include "modules/webaudio/OscillatorNode.h"
 #include "modules/webaudio/PannerNode.h"
 #include "modules/webaudio/PeriodicWave.h"
+#include "modules/webaudio/PeriodicWaveConstraints.h"
 #include "modules/webaudio/ScriptProcessorNode.h"
 #include "modules/webaudio/StereoPannerNode.h"
 #include "modules/webaudio/WaveShaperNode.h"
 #include "platform/ThreadSafeFunctional.h"
 #include "platform/audio/IIRFilter.h"
 #include "public/platform/Platform.h"
 #include "wtf/text/WTFString.h"
 
 namespace blink {
 
@@ skipping 498 matching lines @@
     // called.
 
     return node;
 }
 
 PeriodicWave* AbstractAudioContext::createPeriodicWave(DOMFloat32Array* real, DOMFloat32Array* imag, ExceptionState& exceptionState)
 {
     return PeriodicWave::create(sampleRate(), real, imag, false);
 }
 
-PeriodicWave* AbstractAudioContext::createPeriodicWave(DOMFloat32Array* real, DOMFloat32Array* imag, const Dictionary& options, ExceptionState& exceptionState)
+PeriodicWave* AbstractAudioContext::createPeriodicWave(DOMFloat32Array* real, DOMFloat32Array* imag, const PeriodicWaveConstraints& options, ExceptionState& exceptionState)
 {
     ASSERT(isMainThread());
 
     if (isContextClosed()) {
         throwExceptionForClosedState(exceptionState);
         return nullptr;
     }
 
     if (real->length() != imag->length()) {
         exceptionState.throwDOMException(
             IndexSizeError,
             "length of real array (" + String::number(real->length())
             + ") and length of imaginary array (" +  String::number(imag->length())
             + ") must match.");
         return nullptr;
     }
 
     bool isNormalizationDisabled = false;
-    DictionaryHelper::getWithUndefinedOrNullCheck(options, "disableNormalization", isNormalizationDisabled);
+    if (options.hasDisableNormalization())

[Rick Byers, 2016/05/05 14:13:39]

nit: since this is a required dictionary member (with a default value) I believe
you can simplify this (and avoid specifying the default value in both the IDL
and CPP) with just:

bool isNormalizationDisabled = options.disableNormalization();

[Raymond Toy, 2016/05/05 17:11:46]

Done.  Removed the default value from the IDL was well.

+        isNormalizationDisabled = options.disableNormalization();
 
     return PeriodicWave::create(sampleRate(), real, imag, isNormalizationDisabled);
 }
 
 IIRFilterNode* AbstractAudioContext::createIIRFilter(Vector<double> feedforwardCoef, Vector<double> feedbackCoef,  ExceptionState& exceptionState)
 {
     ASSERT(isMainThread());
 
     if (isContextClosed()) {
         throwExceptionForClosedState(exceptionState);
@@ skipping 351 matching lines @@
 SecurityOrigin* AbstractAudioContext::getSecurityOrigin() const
 {
     if (getExecutionContext())
         return getExecutionContext()->getSecurityOrigin();
 
     return nullptr;
 }
 
 } // namespace blink