Remove FWL_WGTHITTEST_* defines in favour of enum class.

Remove FWL_WGTHITTEST_* defines in favour of enum class.

This Cl updates the FWL_WGTHITTEST_ defines to an enum class and fixes up any
code issues.

Committed: https://pdfium.googlesource.com/pdfium/+/89fcde88f0c03da77d7fd83dece7726d66fd190e

[dsinclair, 2016-05-03 18:13:08]

dsinclair@chromium.org changed reviewers:
+ thestig@chromium.org, tsepez@chromium.org

[dsinclair, 2016-05-03 18:13:09]

PTAL.

[Tom Sepez, 2016-05-03 18:33:19]

LGTM otherwise.

https://codereview.chromium.org/1948583002/diff/1/fpdfsdk/fsdk_annothandler.cpp
File fpdfsdk/fsdk_annothandler.cpp (right):

https://codereview.chromium.org/1948583002/diff/1/fpdfsdk/fsdk_annothandler.c...
fpdfsdk/fsdk_annothandler.cpp:823: return (dwHitTest !=
FWL_WidgetHitTest::Unknown);
nit: overparenthesized.

https://codereview.chromium.org/1948583002/diff/1/xfa/fwl/core/include/fwl_wi...
File xfa/fwl/core/include/fwl_widgethittest.h (right):

https://codereview.chromium.org/1948583002/diff/1/xfa/fwl/core/include/fwl_wi...
xfa/fwl/core/include/fwl_widgethittest.h:10: enum class FWL_WidgetHitTest {
Can we call this FWL_WidgetHit?  It's not really a "hit test".  It may be a "hit
test result".  A hit test enum would describe types of hit tests, e.g. "hit test
using magic", "hit test using particles", etc.

[dsinclair, 2016-05-03 19:34:48]

https://codereview.chromium.org/1948583002/diff/1/fpdfsdk/fsdk_annothandler.cpp
File fpdfsdk/fsdk_annothandler.cpp (right):

https://codereview.chromium.org/1948583002/diff/1/fpdfsdk/fsdk_annothandler.c...
fpdfsdk/fsdk_annothandler.cpp:823: return (dwHitTest !=
FWL_WidgetHitTest::Unknown);
On 2016/05/03 18:33:19, Tom Sepez wrote:
> nit: overparenthesized.

Done.

https://codereview.chromium.org/1948583002/diff/1/xfa/fwl/core/include/fwl_wi...
File xfa/fwl/core/include/fwl_widgethittest.h (right):

https://codereview.chromium.org/1948583002/diff/1/xfa/fwl/core/include/fwl_wi...
xfa/fwl/core/include/fwl_widgethittest.h:10: enum class FWL_WidgetHitTest {
On 2016/05/03 18:33:19, Tom Sepez wrote:
> Can we call this FWL_WidgetHit?  It's not really a "hit test".  It may be a
"hit
> test result".  A hit test enum would describe types of hit tests, e.g. "hit
test
> using magic", "hit test using particles", etc. 

Done.

[dsinclair, 2016-05-03 19:35:05]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-05-03 19:35:06]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/1948583002/#ps20001
(title: " ")

[commit-bot: I haz the power, 2016-05-03 19:35:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1948583002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1948583002/20001

[commit-bot: I haz the power, 2016-05-03 20:00:29]

Description was changed from

==========
Remove FWL_WGTHITTEST_* defines in favour of enum class.

This Cl updates the FWL_WGTHITTEST_ defines to an enum class and fixes up any
code issues.
==========

to

==========
Remove FWL_WGTHITTEST_* defines in favour of enum class.

This Cl updates the FWL_WGTHITTEST_ defines to an enum class and fixes up any
code issues.

Committed:
https://pdfium.googlesource.com/pdfium/+/89fcde88f0c03da77d7fd83dece7726d66fd...
==========

[commit-bot: I haz the power, 2016-05-03 20:00:30]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/89fcde88f0c03da77d7fd83dece7726d66fd...