xfa/fwl/core/include/fwl_widgethittest.h - Issue 1948583002: Remove FWL_WGTHITTEST_* defines in favour of enum class.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: xfa/fwl/core/include/fwl_widgethittest.h

Issue 1948583002: Remove FWL_WGTHITTEST_* defines in favour of enum class. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2016 PDFium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com

	6

	7 #ifndef XFA_FWL_CORE_INCLUDE_FWL_WIDGETHITTEST_H_

	8 #define XFA_FWL_CORE_INCLUDE_FWL_WIDGETHITTEST_H_

	9

	10 enum class FWL_WidgetHitTest {
	Tom Sepez 2016/05/03 18:33:19 Can we call this FWL_WidgetHit? It's not really a Can we call this FWL_WidgetHit? It's not really a "hit test". It may be a "hit test result". A hit test enum would describe types of hit tests, e.g. "hit test using magic", "hit test using particles", etc. dsinclair 2016/05/03 19:34:48 Done. Show quoted text On 2016/05/03 18:33:19, Tom Sepez wrote: > Can we call this FWL_WidgetHit? It's not really a "hit test". It may be a "hit > test result". A hit test enum would describe types of hit tests, e.g. "hit test > using magic", "hit test using particles", etc. Done.
	11 Unknown = 0,

	12 Client,

	13 Left,

	14 Top,

	15 Right,

	16 Bottom,

	17 LeftTop,

	18 RightTop,

	19 LeftBottom,

	20 RightBottom,

	21 Titlebar,

	22 MinBox,

	23 MaxBox,

	24 CloseBox,

	25 HScrollBar,

	26 VScrollBar,

	27 Border,

	28 Edge,

	29 Edit,

	30 HyperLink,

	31 UpButton,

	32 DownButton

	33 };

	34

	35 #endif // XFA_FWL_CORE_INCLUDE_FWL_WIDGETHITTEST_H_

OLD	NEW