Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Unified Diff: chrome/android/BUILD.gn

Issue 1948503002: 🌞 Upstream targets for building native libraries for chrome/monochrome. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/BUILD.gn
diff --git a/chrome/android/BUILD.gn b/chrome/android/BUILD.gn
index 52c207cc694369c6a963c0162b1ad4aa414369ed..8e5c807c0b3dad56c736997ab55d2273de9ae43d 100644
--- a/chrome/android/BUILD.gn
+++ b/chrome/android/BUILD.gn
@@ -428,12 +428,46 @@ jinja_template_resources("chrome_sync_shell_apk_template_resources") {
}
# GYP: //chrome/android/chrome_apk.gyp:libchrome_public
+# TODO(yfriedman): Remove and re-use chrome target.
shared_library("chrome_public") {
deps = [
"//build/config/sanitizers:deps",
"//chrome:chrome_android_core",
]
- sources = chrome_apk_gypi.chrome_public_app_native_sources
+ sources = chrome_apk_gypi.chrome_app_native_sources
+}
+
+# GYP: none
+shared_library("chrome") {
+ sources = chrome_apk_gypi.chrome_app_native_sources
+ deps = [
+ "//build/config/sanitizers:deps",
+ "//chrome:chrome_android_core",
+ ]
+
+ if (is_android && use_order_profiling) {
+ deps += [ "//tools/cygprofile" ]
+ }
+
+ public_configs = extra_chrome_shared_library_configs
+}
+
+# GYP: none
+if (!defined(webview_only_libmonochrome) || !webview_only_libmonochrome) {
+ shared_library("monochrome") {
Yaron 2016/05/03 15:19:41 err, I also omitted the "lib" prefix in these vers
Torne 2016/05/04 12:33:04 It's also redundant in gyp ;)
Yaron 2016/05/04 13:07:44 oh. I vaguely recall it not being redundant at one
+ sources = chrome_apk_gypi.monochrome_app_native_sources
+ deps = [
+ "//android_webview:common",
+ "//chrome:chrome_android_core",
+ ]
+
+ configs -= [ "//build/config/android:hide_native_jni_exports" ]
+ if (is_android && use_order_profiling) {
+ deps += [ "//tools/cygprofile" ]
michaelbai 2016/05/03 19:30:17 Question, Is this sufficient to use order profilin
Yaron 2016/05/03 20:14:48 the shared library config below is the key thing.
michaelbai 2016/05/03 20:54:01 I have never applied the order profiling to monoch
+ }
+
+ public_configs = extra_chrome_shared_library_configs
+ }
}
# GYP: //chrome/android/chrome_apk.gyp:libchrome_sync_shell

Powered by Google App Engine
This is Rietveld 408576698