🌞 Upstream targets for building native libraries for chrome/monochrome.

chrome/android/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/android/config.gni")
 import("//build/config/android/rules.gni")
 import("//build_overrides/v8.gni")
 import("//chrome/android/chrome_public_apk_tmpl.gni")
 import("//chrome/common/features.gni")
 import("//chrome/version.gni")
@@ skipping 410 matching lines @@
 jinja_template_resources("chrome_sync_shell_apk_template_resources") {
   resources = [
     "java/res_template/xml/searchable.xml",
     "java/res_template/xml/syncadapter.xml",
   ]
   res_dir = "java/res_template"
   variables = chrome_sync_shell_jinja_variables
 }
 
 # GYP: //chrome/android/chrome_apk.gyp:libchrome_public
+# TODO(yfriedman): Remove and re-use chrome target.
 shared_library("chrome_public") {
   deps = [
     "//build/config/sanitizers:deps",
     "//chrome:chrome_android_core",
   ]
-  sources = chrome_apk_gypi.chrome_public_app_native_sources
+  sources = chrome_apk_gypi.chrome_app_native_sources
+}
+
+# GYP: none
+shared_library("chrome") {
+  sources = chrome_apk_gypi.chrome_app_native_sources
+  deps = [
+    "//build/config/sanitizers:deps",
+    "//chrome:chrome_android_core",
+  ]
+
+  if (is_android && use_order_profiling) {
+    deps += [ "//tools/cygprofile" ]
+  }
+
+  public_configs = extra_chrome_shared_library_configs
+}
+
+# GYP: none
+if (!defined(webview_only_libmonochrome) || !webview_only_libmonochrome) {
+  shared_library("monochrome") {

[Yaron, 2016/05/03 15:19:41]

err, I also omitted the "lib" prefix in these versions which I thought is
redundant in GN

[Torne, 2016/05/04 12:33:04]

It's also redundant in gyp ;)

[Yaron, 2016/05/04 13:07:44]

oh. I vaguely recall it not being redundant at one point back in the android
backend generator days but perhaps you fixed that? :)

+    sources = chrome_apk_gypi.monochrome_app_native_sources
+    deps = [
+      "//android_webview:common",
+      "//chrome:chrome_android_core",
+    ]
+
+    configs -= [ "//build/config/android:hide_native_jni_exports" ]
+    if (is_android && use_order_profiling) {
+      deps += [ "//tools/cygprofile" ]

[michaelbai, 2016/05/03 19:30:17]

Question, Is this sufficient to use order profiling? Any other needed?

[Yaron, 2016/05/03 20:14:48]

the shared library config below is the key thing. you can see the definition of
it in the internal repo:
https://chrome-internal-review.googlesource.com/#/c/257658/

[michaelbai, 2016/05/03 20:54:01]

I have never applied the order profiling to monochrome, should it just work?

+    }
+
+    public_configs = extra_chrome_shared_library_configs
+  }
 }
 
 # GYP: //chrome/android/chrome_apk.gyp:libchrome_sync_shell
 shared_library("chrome_sync_shell") {
   testonly = true
   deps = [
     "//build/config/sanitizers:deps",
     "//chrome:chrome_android_core",
     "//sync",
     "//sync:test_support_sync_fake_server_android",
@@ skipping 117 matching lines @@
 instrumentation_test_apk("chrome_sync_shell_test_apk") {
   apk_name = "ChromeSyncShellTest"
   apk_under_test = ":chrome_sync_shell_apk"
   android_manifest = chrome_sync_shell_test_apk_manifest
   deps = [
     ":chrome_sync_shell_test_apk_java",
     ":chrome_sync_shell_test_apk_manifest",
   ]
   proguard_enabled = !is_debug
 }