Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 1948443002: [turbofan] Make Pipeline an all-static class. (Closed)

Created:
4 years, 7 months ago by Michael Starzinger
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_cleanup-pipeline-2
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Make Pipeline an all-static class. This moves all implementation internals of the Pipeline class into the corresponding cc-file. Only the public API remains in the header and is made up of static functions only. R=bmeurer@chromium.org Committed: https://crrev.com/f71e1664718fa45b968a0cb595caa713edffb387 Cr-Commit-Position: refs/heads/master@{#35987}

Patch Set 1 #

Patch Set 2 : Fix preventing construction. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -60 lines) Patch
M src/compiler/pipeline.h View 1 2 chunks +2 lines, -37 lines 0 comments Download
M src/compiler/pipeline.cc View 15 chunks +52 lines, -23 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (4 generated)
Michael Starzinger
4 years, 7 months ago (2016-05-03 12:09:07 UTC) #1
ahaas
lgtm I like it!
4 years, 7 months ago (2016-05-03 13:15:57 UTC) #3
Jarin
lgtm, very nice!
4 years, 7 months ago (2016-05-03 14:05:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1948443002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1948443002/20001
4 years, 7 months ago (2016-05-03 14:13:37 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-03 14:15:11 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 14:16:53 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f71e1664718fa45b968a0cb595caa713edffb387
Cr-Commit-Position: refs/heads/master@{#35987}

Powered by Google App Engine
This is Rietveld 408576698