Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Unified Diff: src/compiler/pipeline.h

Issue 1948443002: [turbofan] Make Pipeline an all-static class. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@local_cleanup-pipeline-2
Patch Set: Fix preventing construction. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/compiler/pipeline.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/pipeline.h
diff --git a/src/compiler/pipeline.h b/src/compiler/pipeline.h
index 66eb33734b75e69e4ea60fe4a7c898393a19c04b..64befbfe064ceb078a376b59f3af7b8b7bc6a027 100644
--- a/src/compiler/pipeline.h
+++ b/src/compiler/pipeline.h
@@ -21,12 +21,10 @@ namespace compiler {
class CallDescriptor;
class Graph;
class InstructionSequence;
-class Linkage;
-class PipelineData;
class Schedule;
class SourcePositionTable;
-class Pipeline {
+class Pipeline : public AllStatic {
public:
// Returns a new compilation job for the given function.
static CompilationJob* NewCompilationJob(Handle<JSFunction> function);
@@ -67,40 +65,7 @@ class Pipeline {
Schedule* schedule = nullptr);
private:
- friend class PipelineCompilationJob;
- friend class PipelineWasmCompilationJob;
-
- explicit Pipeline(PipelineData* data) : data_(data) {}
-
- // Helpers for executing pipeline phases.
- template <typename Phase>
- void Run();
- template <typename Phase, typename Arg0>
- void Run(Arg0 arg_0);
- template <typename Phase, typename Arg0, typename Arg1>
- void Run(Arg0 arg_0, Arg1 arg_1);
-
- // Run the graph creation and initial optimization passes.
- bool CreateGraph();
-
- // Run the concurrent optimization passes.
- bool OptimizeGraph(Linkage* linkage);
-
- // Perform the actual code generation and return handle to a code object.
- Handle<Code> GenerateCode(Linkage* linkage);
-
- bool ScheduleAndSelectInstructions(Linkage* linkage);
- void RunPrintAndVerify(const char* phase, bool untyped = false);
- Handle<Code> ScheduleAndGenerateCode(CallDescriptor* call_descriptor);
- void AllocateRegisters(const RegisterConfiguration* config,
- CallDescriptor* descriptor, bool run_verifier);
-
- CompilationInfo* info() const;
- Isolate* isolate() const;
-
- PipelineData* const data_;
-
- DISALLOW_COPY_AND_ASSIGN(Pipeline);
+ DISALLOW_IMPLICIT_CONSTRUCTORS(Pipeline);
};
} // namespace compiler
« no previous file with comments | « no previous file | src/compiler/pipeline.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698