Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1948363002: [Android] Remove dedicated presubmit for build/andorid/pylib/symbols/. (Closed)

Created:
4 years, 7 months ago by jbudorick
Modified:
4 years, 7 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Remove dedicated presubmit for build/andorid/pylib/symbols/. BUG= Committed: https://crrev.com/a32daec771a2229990f355ceeaa32aa663af6d3e Cr-Commit-Position: refs/heads/master@{#391841}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -35 lines) Patch
M build/android/PRESUBMIT.py View 2 chunks +2 lines, -2 lines 0 comments Download
D build/android/pylib/symbols/PRESUBMIT.py View 1 chunk +0 lines, -21 lines 0 comments Download
M build/android/pylib/symbols/elf_symbolizer.py View 7 chunks +9 lines, -8 lines 0 comments Download
M build/android/pylib/symbols/elf_symbolizer_unittest.py View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
jbudorick
4 years, 7 months ago (2016-05-05 16:15:53 UTC) #2
mikecase (-- gone --)
lgtm
4 years, 7 months ago (2016-05-05 16:26:45 UTC) #3
rnephew (Reviews Here)
On 2016/05/05 16:15:53, jbudorick wrote: lgtm
4 years, 7 months ago (2016-05-05 16:27:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1948363002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1948363002/1
4 years, 7 months ago (2016-05-05 16:28:22 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-05 17:59:04 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-05 18:00:38 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/a32daec771a2229990f355ceeaa32aa663af6d3e
Cr-Commit-Position: refs/heads/master@{#391841}

Powered by Google App Engine
This is Rietveld 408576698