Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: build/android/PRESUBMIT.py

Issue 1948363002: [Android] Remove dedicated presubmit for build/andorid/pylib/symbols/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build/android/pylib/symbols/PRESUBMIT.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Presubmit script for android buildbot. 5 """Presubmit script for android buildbot.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for
8 details on the presubmit API built into depot_tools. 8 details on the presubmit API built into depot_tools.
9 """ 9 """
10 10
11 11
12 def CommonChecks(input_api, output_api): 12 def CommonChecks(input_api, output_api):
13 output = [] 13 output = []
14 14
15 build_android_dir = input_api.PresubmitLocalPath() 15 build_android_dir = input_api.PresubmitLocalPath()
16 16
17 def J(*dirs): 17 def J(*dirs):
18 """Returns a path relative to presubmit directory.""" 18 """Returns a path relative to presubmit directory."""
19 return input_api.os_path.join(build_android_dir, *dirs) 19 return input_api.os_path.join(build_android_dir, *dirs)
20 20
21 build_pys = [ 21 build_pys = [
22 r'gyp/.*\.py$', 22 r'gyp/.*\.py$',
23 r'gn/.*\.py', 23 r'gn/.*\.py',
24 r'incremental_install/.*\.py', 24 r'incremental_install/.*\.py',
25 ] 25 ]
26 output.extend(input_api.canned_checks.RunPylint( 26 output.extend(input_api.canned_checks.RunPylint(
27 input_api, 27 input_api,
28 output_api, 28 output_api,
29 pylintrc='pylintrc', 29 pylintrc='pylintrc',
30 # symbols has their own PRESUBMIT.py 30 black_list=build_pys,
31 black_list=build_pys + [r'pylib/symbols/.*\.py$'],
32 extra_paths_list=[ 31 extra_paths_list=[
33 J(), 32 J(),
34 J('buildbot'), 33 J('buildbot'),
35 J('..', '..', 'third_party', 'catapult', 'devil') 34 J('..', '..', 'third_party', 'catapult', 'devil')
36 ])) 35 ]))
37 output.extend(input_api.canned_checks.RunPylint( 36 output.extend(input_api.canned_checks.RunPylint(
38 input_api, 37 input_api,
39 output_api, 38 output_api,
40 white_list=build_pys, 39 white_list=build_pys,
41 extra_paths_list=[J('gyp'), J('gn')])) 40 extra_paths_list=[J('gyp'), J('gn')]))
(...skipping 12 matching lines...) Expand all
54 output_api, 53 output_api,
55 unit_tests=[ 54 unit_tests=[
56 J('.', 'emma_coverage_stats_test.py'), 55 J('.', 'emma_coverage_stats_test.py'),
57 J('gyp', 'util', 'md5_check_test.py'), 56 J('gyp', 'util', 'md5_check_test.py'),
58 J('play_services', 'update_test.py'), 57 J('play_services', 'update_test.py'),
59 J('pylib', 'base', 'test_dispatcher_unittest.py'), 58 J('pylib', 'base', 'test_dispatcher_unittest.py'),
60 J('pylib', 'gtest', 'gtest_test_instance_test.py'), 59 J('pylib', 'gtest', 'gtest_test_instance_test.py'),
61 J('pylib', 'instrumentation', 60 J('pylib', 'instrumentation',
62 'instrumentation_test_instance_test.py'), 61 'instrumentation_test_instance_test.py'),
63 J('pylib', 'results', 'json_results_test.py'), 62 J('pylib', 'results', 'json_results_test.py'),
63 J('pylib', 'symbols', 'elf_symbolizer_unittest.py'),
64 ], 64 ],
65 env=pylib_test_env)) 65 env=pylib_test_env))
66 66
67 return output 67 return output
68 68
69 69
70 def CheckChangeOnUpload(input_api, output_api): 70 def CheckChangeOnUpload(input_api, output_api):
71 return CommonChecks(input_api, output_api) 71 return CommonChecks(input_api, output_api)
72 72
73 73
74 def CheckChangeOnCommit(input_api, output_api): 74 def CheckChangeOnCommit(input_api, output_api):
75 return CommonChecks(input_api, output_api) 75 return CommonChecks(input_api, output_api)
OLDNEW
« no previous file with comments | « no previous file | build/android/pylib/symbols/PRESUBMIT.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698