[reland] Browser Side Text Input State Tracking for OOPIF (Aura Only)

content/browser/web_contents/web_contents_impl.h

Index: content/browser/web_contents/web_contents_impl.h
diff --git a/content/browser/web_contents/web_contents_impl.h b/content/browser/web_contents/web_contents_impl.h
index 92919be4ea74b72d27e8cfb3f6e86fcb829f79f6..b8706e5a23774075ade601d6ef21bf0b25fb540b 100644
--- a/content/browser/web_contents/web_contents_impl.h
+++ b/content/browser/web_contents/web_contents_impl.h
@@ -73,6 +73,7 @@ class SavePackage;
 class ScreenOrientationDispatcherHost;
 class SiteInstance;
 class TestWebContents;
+class TextInputManager;
 class WakeLockServiceContext;
 class WebContentsAudioMuter;
 class WebContentsDelegate;
@@ -630,6 +631,7 @@ class CONTENT_EXPORT WebContentsImpl
                               const std::vector<uint8_t>& proto) override;
   void OnRenderFrameProxyVisibilityChanged(bool visible) override;
   void SendScreenRects() override;
+  TextInputManager* GetTextInputManager() override;
 
   // RenderFrameHostManager::Delegate ------------------------------------------
 
@@ -1375,6 +1377,14 @@ private:
 
   bool page_scale_factor_is_one_;
 
+  // The TextInputManager instance for WebContents. The manager will track the

[Charlie Reis, 2016/05/26 06:22:05]

nit: TextInputManager tracks the IME-related...
(Drop the first part, which is clear from the context.)

[EhsanK, 2016/05/30 15:06:09]

Acknowledged.

+  // IME-related state for all the RenderWidgets on this tab. Only exists on the
+  // outer WebContents and is automatically destroyed when a WebContents

[Charlie Reis, 2016/05/26 06:22:05]

nit: outer-most

[EhsanK, 2016/05/30 15:06:09]

Done. Put 'outermost' rather than 'outer-most' as the former is a word with the
intended meaning; unless we use outer-most for another reason?
(search in content/ 443 instances of outermost vs 22 for outer-most; spooky btw
since both relate to port numbers with secure connections - and you work on
Chrome security! #texassharpshooterfallacy).

[Charlie Reis, 2016/06/02 22:03:29]

Outermost is fine, thanks.

+  // becomes inner WebContents by attaching to an outer WebContents. Then the

[Charlie Reis, 2016/05/26 06:22:05]

nit: an inner

[EhsanK, 2016/05/30 15:06:08]

Done.

+  // IME-related state for RenderWidgetHost on the inner WebContents are tracked

[Charlie Reis, 2016/05/26 06:22:05]

nit: RenderWidgetHosts

nit: s/are/is/
(state ... is tracked)

[EhsanK, 2016/05/30 15:06:09]

Acknowledged.

+  // by the TextInputManager in the outer WebContents.
+  std::unique_ptr<TextInputManager> text_input_manager_;
+
   base::WeakPtrFactory<WebContentsImpl> loading_weak_factory_;
   base::WeakPtrFactory<WebContentsImpl> weak_factory_;