[reland] Browser Side Text Input State Tracking for OOPIF (Aura Only)

content/browser/web_contents/web_contents_impl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_
 #define CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_
 
 #include <stdint.h>
 
 #include <functional>
@@ skipping 55 matching lines @@
 class PluginContentOriginWhitelist;
 class PowerSaveBlocker;
 class RenderViewHost;
 class RenderViewHostDelegateView;
 class RenderWidgetHostImpl;
 class RenderWidgetHostInputEventRouter;
 class SavePackage;
 class ScreenOrientationDispatcherHost;
 class SiteInstance;
 class TestWebContents;
+class TextInputManager;
 class WakeLockServiceContext;
 class WebContentsAudioMuter;
 class WebContentsDelegate;
 class WebContentsImpl;
 class WebContentsView;
 class WebContentsViewDelegate;
 struct AXEventNotificationDetails;
 struct ColorSuggestion;
 struct FaviconURL;
 struct LoadNotificationDetails;
@@ skipping 537 matching lines @@
   bool IsFullscreenForCurrentTab(
       RenderWidgetHostImpl* render_widget_host) const override;
   blink::WebDisplayMode GetDisplayMode(
       RenderWidgetHostImpl* render_widget_host) const override;
   void LostCapture(RenderWidgetHostImpl* render_widget_host) override;
   void LostMouseLock(RenderWidgetHostImpl* render_widget_host) override;
   void ForwardCompositorProto(RenderWidgetHostImpl* render_widget_host,
                               const std::vector<uint8_t>& proto) override;
   void OnRenderFrameProxyVisibilityChanged(bool visible) override;
   void SendScreenRects() override;
+  TextInputManager* GetTextInputManager() override;
 
   // RenderFrameHostManager::Delegate ------------------------------------------
 
   bool CreateRenderViewForRenderManager(
       RenderViewHost* render_view_host,
       int opener_frame_routing_id,
       int proxy_routing_id,
       const FrameReplicationState& replicated_frame_state) override;
   void CreateRenderWidgetHostViewForRenderManager(
       RenderViewHost* render_view_host) override;
@@ skipping 725 matching lines @@
 
   // Manages media players, CDMs, and power save blockers for media.
   std::unique_ptr<MediaWebContentsObserver> media_web_contents_observer_;
 
   std::unique_ptr<RenderWidgetHostInputEventRouter> rwh_input_event_router_;
 
   PageImportanceSignals page_importance_signals_;
 
   bool page_scale_factor_is_one_;
 
+  // The TextInputManager instance for WebContents. The manager will track the

[Charlie Reis, 2016/05/26 06:22:05]

nit: TextInputManager tracks the IME-related...
(Drop the first part, which is clear from the context.)

[EhsanK, 2016/05/30 15:06:09]

Acknowledged.

+  // IME-related state for all the RenderWidgets on this tab. Only exists on the
+  // outer WebContents and is automatically destroyed when a WebContents

[Charlie Reis, 2016/05/26 06:22:05]

nit: outer-most

[EhsanK, 2016/05/30 15:06:09]

Done. Put 'outermost' rather than 'outer-most' as the former is a word with the
intended meaning; unless we use outer-most for another reason?
(search in content/ 443 instances of outermost vs 22 for outer-most; spooky btw
since both relate to port numbers with secure connections - and you work on
Chrome security! #texassharpshooterfallacy).

[Charlie Reis, 2016/06/02 22:03:29]

Outermost is fine, thanks.

+  // becomes inner WebContents by attaching to an outer WebContents. Then the

[Charlie Reis, 2016/05/26 06:22:05]

nit: an inner

[EhsanK, 2016/05/30 15:06:08]

Done.

+  // IME-related state for RenderWidgetHost on the inner WebContents are tracked

[Charlie Reis, 2016/05/26 06:22:05]

nit: RenderWidgetHosts

nit: s/are/is/
(state ... is tracked)

[EhsanK, 2016/05/30 15:06:09]

Acknowledged.

+  // by the TextInputManager in the outer WebContents.
+  std::unique_ptr<TextInputManager> text_input_manager_;
+
   base::WeakPtrFactory<WebContentsImpl> loading_weak_factory_;
   base::WeakPtrFactory<WebContentsImpl> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(WebContentsImpl);
 };
 
 // Dangerous methods which should never be made part of the public API, so we
 // grant their use only to an explicit friend list (c++ attorney/client idiom).
 class CONTENT_EXPORT WebContentsImpl::FriendZone {
  private:
   friend class TestNavigationObserver;
   friend class WebContentsAddedObserver;
   friend class ContentBrowserSanityChecker;
 
   FriendZone();  // Not instantiable.
 
   // Adds/removes a callback called on creation of each new WebContents.
   static void AddCreatedCallbackForTesting(const CreatedCallback& callback);
   static void RemoveCreatedCallbackForTesting(const CreatedCallback& callback);
 
   DISALLOW_COPY_AND_ASSIGN(FriendZone);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_