Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1548)

Unified Diff: content/browser/renderer_host/render_widget_host_view_aura.h

Issue 1948343002: [reland] Browser Side Text Input State Tracking for OOPIF (Aura Only) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing shuchen@ and kenrb@ comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_aura.h
diff --git a/content/browser/renderer_host/render_widget_host_view_aura.h b/content/browser/renderer_host/render_widget_host_view_aura.h
index 51942cd96d961b17e3b8be7071351206533562de..64e6dd7fb0b586cfcb2b5a56e9a977829e57e5d9 100644
--- a/content/browser/renderer_host/render_widget_host_view_aura.h
+++ b/content/browser/renderer_host/render_widget_host_view_aura.h
@@ -134,7 +134,6 @@ class CONTENT_EXPORT RenderWidgetHostViewAura
void Focus() override;
void UpdateCursor(const WebCursor& cursor) override;
void SetIsLoading(bool is_loading) override;
- void TextInputStateChanged(const TextInputState& params) override;
void ImeCancelComposition() override;
void ImeCompositionRangeChanged(
const gfx::Range& range,
@@ -342,6 +341,7 @@ class CONTENT_EXPORT RenderWidgetHostViewAura
private:
friend class RenderWidgetHostViewAuraCopyRequestTest;
+ friend class TestInputMethodObserver;
FRIEND_TEST_ALL_PREFIXES(RenderWidgetHostViewAuraTest,
PopupRetainsCaptureAfterMouseRelease);
FRIEND_TEST_ALL_PREFIXES(RenderWidgetHostViewAuraTest, SetCompositionText);
@@ -518,6 +518,12 @@ class CONTENT_EXPORT RenderWidgetHostViewAura
// NULL on failure.
RenderViewHostDelegateView* GetRenderViewHostDelegateView();
+ // TextInputManager::Observer implementation.
+ void OnTextInputStateUpdated(TextInputManager* text_input_manager,
+ RenderWidgetHostViewBase* updated_view) override;
+ void OnTextInputStateUpdateCalled(
+ TextInputManager* text_input_manager) override;
+
// The model object.
RenderWidgetHostImpl* const host_;
@@ -561,14 +567,6 @@ class CONTENT_EXPORT RenderWidgetHostViewAura
// object.
ui::MotionEventAura pointer_state_;
- // The current text input type.
- ui::TextInputType text_input_type_;
- // The current text input mode corresponding to HTML5 inputmode attribute.
- ui::TextInputMode text_input_mode_;
- // The current text input flags.
- int text_input_flags_;
- bool can_compose_inline_;
-
// Bounds for the selection.
ui::SelectionBound selection_anchor_;
ui::SelectionBound selection_focus_;

Powered by Google App Engine
This is Rietveld 408576698