Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Unified Diff: content/browser/frame_host/render_widget_host_view_child_frame.cc

Issue 1948343002: [reland] Browser Side Text Input State Tracking for OOPIF (Aura Only) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing shuchen@ and kenrb@ comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_widget_host_view_child_frame.cc
diff --git a/content/browser/frame_host/render_widget_host_view_child_frame.cc b/content/browser/frame_host/render_widget_host_view_child_frame.cc
index 62bb821e9acf2f687cf4ab31fbd2a6102b3fdb3b..972b53bf2868ebaa0544de60802a35adfe775904 100644
--- a/content/browser/frame_host/render_widget_host_view_child_frame.cc
+++ b/content/browser/frame_host/render_widget_host_view_child_frame.cc
@@ -51,6 +51,10 @@ RenderWidgetHostViewChildFrame::RenderWidgetHostViewChildFrame(
RegisterSurfaceNamespaceId();
host_->SetView(this);
+
+ // This is necessary when this view is the top-level view, which is the case
+ // for inner WebContents.
+ text_input_manager_ = GetTextInputManager();
EhsanK 2016/05/13 16:00:56 Actually, I am not sure if this is really necessar
}
RenderWidgetHostViewChildFrame::~RenderWidgetHostViewChildFrame() {
@@ -260,11 +264,6 @@ void RenderWidgetHostViewChildFrame::SetIsLoading(bool is_loading) {
NOTREACHED();
}
-void RenderWidgetHostViewChildFrame::TextInputStateChanged(
- const TextInputState& params) {
- // TODO(kenrb): Implement.
-}
-
void RenderWidgetHostViewChildFrame::RenderProcessGone(
base::TerminationStatus status,
int error_code) {

Powered by Google App Engine
This is Rietveld 408576698