Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 1948313002: Revert of SkOncePtr -> SkOnce (Closed)

Created:
4 years, 7 months ago by reed1
Modified:
4 years, 7 months ago
Reviewers:
herb_g, mtklein_C
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of SkOncePtr -> SkOnce (patchset #1 id:1 of https://codereview.chromium.org/1949313003/ ) Reason for revert: ok, I have no idea what's going on Original issue's description: > Reland of SkOncePtr -> SkOnce (patchset #1 id:1 of https://codereview.chromium.org/1945293004/ ) > > Reason for revert: > previous revert unneeded (I think) > > Original issue's description: > > Revert of SkOncePtr -> SkOnce (patchset #4 id:60001 of https://codereview.chromium.org/1953533002/ ) > > > > Reason for revert: > > broken the Mac and Linux builders, e.g.: > > > > https://build.chromium.org/p/chromium/builders/Mac/builds/15151 > > https://build.chromium.org/p/chromium/builders/Linux%20x64/builds/19052 > > > > Original issue's description: > > > SkOncePtr -> SkOnce > > > > > > It's always nice to kill off a synchronization primitive. > > > And while less terse, I think this new code reads more clearly. > > > > > > ... and, SkOncePtr's tests were the only thing now using sk_num_cores() > > > outside of SkTaskGroup, so I've hidden it as static inside SkTaskGroup.cpp. > > > > > > BUG=skia: > > > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1953533002 > > > CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot > > > > > > Committed: https://skia.googlesource.com/skia/+/9bd3fc7fa9bb7cad050bd619aa93d4c48ebb5c02 > > > > TBR=herb@google.com,mtklein@chromium.org > > # Skipping CQ checks because original CL landed less than 1 days ago. > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=skia: > > > > Committed: https://skia.googlesource.com/skia/+/7eb33da7eede34c050b865dbb1b60c3dcea7191b > > TBR=herb@google.com,mtklein@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/82da9a8aa0ce648f36882830765b42e0ada6c0fa TBR=herb@google.com,mtklein@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/959a2937d55279c6d020f2511007bb39ed322ace

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+175 lines, -111 lines) Patch
M gyp/core.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A include/private/SkOncePtr.h View 1 chunk +65 lines, -0 lines 0 comments Download
M src/core/SkColorSpace.cpp View 3 chunks +8 lines, -10 lines 0 comments Download
M src/core/SkData.cpp View 2 chunks +4 lines, -6 lines 0 comments Download
M src/core/SkFontMgr.cpp View 2 chunks +5 lines, -8 lines 0 comments Download
M src/core/SkGlyphCache.cpp View 2 chunks +3 lines, -6 lines 0 comments Download
M src/core/SkImageFilterCache.cpp View 2 chunks +3 lines, -6 lines 0 comments Download
M src/core/SkMessageBus.h View 2 chunks +3 lines, -5 lines 0 comments Download
M src/core/SkMiniRecorder.cpp View 3 chunks +3 lines, -7 lines 0 comments Download
M src/core/SkPathRef.cpp View 3 chunks +8 lines, -10 lines 0 comments Download
M src/core/SkTaskGroup.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/core/SkTaskGroup.cpp View 2 chunks +11 lines, -11 lines 0 comments Download
M src/core/SkTypeface.cpp View 2 chunks +5 lines, -7 lines 0 comments Download
M src/core/SkXfermode.cpp View 3 chunks +9 lines, -12 lines 0 comments Download
M src/fonts/SkRemotableFontMgr.cpp View 2 chunks +3 lines, -5 lines 0 comments Download
M src/lazy/SkDiscardableMemoryPool.cpp View 2 chunks +6 lines, -8 lines 0 comments Download
M src/opts/opts_check_x86.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/ports/SkFontHost_mac.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M src/utils/SkEventTracer.cpp View 3 chunks +4 lines, -6 lines 0 comments Download
A tests/OncePtrTest.cpp View 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
reed1
Created Revert of SkOncePtr -> SkOnce
4 years, 7 months ago (2016-05-05 08:36:32 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1948313002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1948313002/1
4 years, 7 months ago (2016-05-05 08:36:34 UTC) #2
commit-bot: I haz the power
4 years, 7 months ago (2016-05-05 08:36:49 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/959a2937d55279c6d020f2511007bb39ed322ace

Powered by Google App Engine
This is Rietveld 408576698