Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Issue 1948233002: Revert "Modernize SkMutex and SkSemaphore." (Closed)

Created:
4 years, 7 months ago by sclittle
Modified:
4 years, 7 months ago
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert "Modernize SkMutex and SkSemaphore." Revert https://codereview.chromium.org/1947153002 since it seems to have broken the Mac and Linux builders, e.g.: https://build.chromium.org/p/chromium/builders/Mac/builds/15151 https://build.chromium.org/p/chromium/builders/Linux%20x64/builds/19052 This also reverts https://codereview.chromium.org/1948193002 because it depends on the earlier CL, https://codereview.chromium.org/1947153002. It looks like https://codereview.chromium.org/1947153002 added static initializers, which caused failures on the Mac and Linux builders. This reverts commit 427c2819d9237d7d7729c59238036cfc73c072ea. This reverts commit 5e56cfd3fa1041dbb83899844fb92fa9a2ef1009. TBR=herb@google.com,mtklein@chromium.org,reed@chromium.org,bsalomon@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1948233002

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+175 lines, -108 lines) Patch
M dm/DM.cpp View 1 chunk +1 line, -1 line 0 comments Download
M dm/DMJsonWriter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M include/core/SkPixelRef.h View 1 chunk +1 line, -1 line 0 comments Download
M include/ports/SkFontConfigInterface.h View 1 chunk +1 line, -0 lines 0 comments Download
M include/private/SkMutex.h View 3 chunks +40 lines, -13 lines 0 comments Download
M include/private/SkSemaphore.h View 2 chunks +53 lines, -43 lines 0 comments Download
M src/core/SkDeviceProfile.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkPaint.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkResourceCache.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkSemaphore.cpp View 4 chunks +38 lines, -11 lines 0 comments Download
M src/core/SkTypeface.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkTypefaceCache.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkGradientShader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/fonts/SkTestScalerContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/lazy/SkDiscardableMemoryPool.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/lazy/SkDiscardableMemoryPool.cpp View 4 chunks +8 lines, -7 lines 0 comments Download
M src/pathops/SkPathOpsDebug.cpp View 5 chunks +6 lines, -6 lines 0 comments Download
M src/pathops/SkPathOpsOp.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/ports/SkFontConfigInterface_direct.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/ports/SkFontHost_FreeType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/ports/SkFontHost_fontconfig.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/ports/SkFontHost_mac.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/ports/SkFontMgr_fontconfig.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/ports/SkTLS_win.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/views/SkEventSink.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/PathOpsExtendedTest.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M tools/gpu/gl/command_buffer/GLTestContext_command_buffer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tools/sk_tool_utils_font.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
sclittle
4 years, 7 months ago (2016-05-04 23:48:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1948233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1948233002/1
4 years, 7 months ago (2016-05-04 23:49:04 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 7 months ago (2016-05-04 23:49:05 UTC) #5
sclittle
4 years, 7 months ago (2016-05-05 00:57:15 UTC) #7
I'm deleting this CL since I've created the revert separately through the UI
instead, and reed@ already reverted https://codereview.chromium.org/1948193002/.

Powered by Google App Engine
This is Rietveld 408576698