Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 1948193002: SK_DECLARE_STATIC_MUTEX -> static SkMutex (Closed)

Created:
4 years, 7 months ago by mtklein_C
Modified:
4 years, 7 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SK_DECLARE_STATIC_MUTEX -> static SkMutex There's no need to use a macro to declare static SkMutexes any more (and there's likewise no need to restrict them to global scope). BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1948193002 Committed: https://skia.googlesource.com/skia/+/5e56cfd3fa1041dbb83899844fb92fa9a2ef1009

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -36 lines) Patch
M dm/DM.cpp View 1 chunk +1 line, -1 line 0 comments Download
M dm/DMJsonWriter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M include/private/SkMutex.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/core/SkDeviceProfile.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkPaint.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkResourceCache.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkTypeface.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkTypefaceCache.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkGradientShader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/fonts/SkTestScalerContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/lazy/SkDiscardableMemoryPool.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/pathops/SkPathOpsDebug.cpp View 5 chunks +6 lines, -6 lines 0 comments Download
M src/pathops/SkPathOpsOp.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/ports/SkFontConfigInterface_direct.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/ports/SkFontHost_FreeType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/ports/SkFontHost_fontconfig.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/ports/SkFontHost_mac.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/ports/SkFontMgr_fontconfig.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/ports/SkTLS_win.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/views/SkEventSink.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/PathOpsExtendedTest.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M tools/gpu/gl/command_buffer/GLTestContext_command_buffer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tools/sk_tool_utils_font.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1948193002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1948193002/1
4 years, 7 months ago (2016-05-04 22:07:33 UTC) #5
mtklein
lgtm
4 years, 7 months ago (2016-05-04 22:19:38 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1948193002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1948193002/1
4 years, 7 months ago (2016-05-04 22:19:44 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/5e56cfd3fa1041dbb83899844fb92fa9a2ef1009
4 years, 7 months ago (2016-05-04 22:21:18 UTC) #12
hal.canary
On 2016/05/04 22:21:18, commit-bot: I haz the power wrote: > Committed patchset #1 (id:1) as ...
4 years, 7 months ago (2016-05-04 23:32:30 UTC) #13
sclittle
I've created a revert of both this CL and https://codereview.chromium.org/1947153002/ to fix failures in the ...
4 years, 7 months ago (2016-05-04 23:58:46 UTC) #14
reed1
4 years, 7 months ago (2016-05-05 00:12:23 UTC) #15
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1945353003/ by reed@google.com.

The reason for reverting is: broken the Mac and Linux builders, e.g.:

https://build.chromium.org/p/chromium/builders/Mac/builds/15151
https://build.chromium.org/p/chromium/builders/Linux%20x64/builds/19052.

Powered by Google App Engine
This is Rietveld 408576698