Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(3)

Issue 1948223005: ChildProcessSecurityPolicy::CanAccessDataForOrigin workaround to suppress bad kills (Closed)

Created:
2 years, 10 months ago by ncarter (slow)
Modified:
2 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

ChildProcessSecurityPolicy::CanAccessDataForOrigin workaround to suppress bad kills crbug.com/600441 apparently involves a race where we check ChildProcessSecurityPolicy for a process_id that it doesn't know -- probably a renderer shutdown race. Returning true instead of false here is a temporary workaround to suppress these bad kills, which are affecting the non-oopif user population. This is a tolerable short-term behavior as far as security is concerned, since CanAccessDataForOrigin is only meant to offer meaningful protection in --site-per-process mode, which is not yet launched. BUG=600441 Review-Url: https://codereview.chromium.org/1945173003 Cr-Commit-Position: refs/heads/master@{#391678} (cherry picked from commit 470457d18d306a0f32ea548ad111371c24e509e1) Committed: https://chromium.googlesource.com/chromium/src/+/36602ec1b414e65ddd7c55d4a27f167174825d9e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -4 lines) Patch
M content/browser/child_process_security_policy_impl.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M content/browser/renderer_host/media/webrtc_identity_service_host_unittest.cc View 2 chunks +14 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
ncarter (slow)
2 years, 10 months ago (2016-05-05 22:47:06 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
36602ec1b414e65ddd7c55d4a27f167174825d9e.

Powered by Google App Engine
This is Rietveld 408576698