Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(8)

Issue 1945173003: ChildProcessSecurityPolicy::CanAccessDataForOrigin workaround to suppress bad kills (Closed)

Created:
2 years, 10 months ago by ncarter (slow)
Modified:
2 years, 10 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, darin-cc_chromium.org, jam, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ChildProcessSecurityPolicy::CanAccessDataForOrigin workaround to suppress bad kills crbug.com/600441 apparently involves a race where we check ChildProcessSecurityPolicy for a process_id that it doesn't know -- probably a renderer shutdown race. Returning true instead of false here is a temporary workaround to suppress these bad kills, which are affecting the non-oopif user population. This is a tolerable short-term behavior as far as security is concerned, since CanAccessDataForOrigin is only meant to offer meaningful protection in --site-per-process mode, which is not yet launched. BUG=600441 Committed: https://crrev.com/470457d18d306a0f32ea548ad111371c24e509e1 Cr-Commit-Position: refs/heads/master@{#391678}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix tests. #

Total comments: 1

Patch Set 3 : Remove NOTREACHED() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -4 lines) Patch
M content/browser/child_process_security_policy_impl.cc View 1 2 1 chunk +5 lines, -2 lines 0 comments Download
M content/browser/renderer_host/media/webrtc_identity_service_host_unittest.cc View 1 2 chunks +14 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (5 generated)
ncarter (slow)
Charlie, PTAL
2 years, 10 months ago (2016-05-04 18:10:18 UTC) #2
Charlie Reis
LGTM if we remove the NOTREACHED. https://codereview.chromium.org/1945173003/diff/1/content/browser/child_process_security_policy_impl.cc File content/browser/child_process_security_policy_impl.cc (right): https://codereview.chromium.org/1945173003/diff/1/content/browser/child_process_security_policy_impl.cc#newcode823 content/browser/child_process_security_policy_impl.cc:823: NOTREACHED(); Let's remove ...
2 years, 10 months ago (2016-05-04 19:38:17 UTC) #3
ncarter (slow)
https://codereview.chromium.org/1945173003/diff/1/content/browser/child_process_security_policy_impl.cc File content/browser/child_process_security_policy_impl.cc (right): https://codereview.chromium.org/1945173003/diff/1/content/browser/child_process_security_policy_impl.cc#newcode823 content/browser/child_process_security_policy_impl.cc:823: NOTREACHED(); On 2016/05/04 19:38:17, Charlie Reis wrote: > Let's ...
2 years, 10 months ago (2016-05-04 19:57:57 UTC) #5
dcheng
Drive-by. https://codereview.chromium.org/1945173003/diff/20001/content/browser/renderer_host/media/webrtc_identity_service_host_unittest.cc File content/browser/renderer_host/media/webrtc_identity_service_host_unittest.cc (right): https://codereview.chromium.org/1945173003/diff/20001/content/browser/renderer_host/media/webrtc_identity_service_host_unittest.cc#newcode24 content/browser/renderer_host/media/webrtc_identity_service_host_unittest.cc:24: const char OTHER_SITE[] = "https://other.com"; =/ Can we ...
2 years, 10 months ago (2016-05-04 20:00:40 UTC) #6
ncarter (slow)
On 2016/05/04 20:00:40, dcheng wrote: > Drive-by. > > https://codereview.chromium.org/1945173003/diff/20001/content/browser/renderer_host/media/webrtc_identity_service_host_unittest.cc > File > content/browser/renderer_host/media/webrtc_identity_service_host_unittest.cc > ...
2 years, 10 months ago (2016-05-04 20:11:20 UTC) #7
dcheng
On 2016/05/04 at 20:11:20, nick wrote: > On 2016/05/04 20:00:40, dcheng wrote: > > Drive-by. ...
2 years, 10 months ago (2016-05-04 20:14:46 UTC) #8
ncarter (slow)
On 2016/05/04 20:14:46, dcheng wrote: > On 2016/05/04 at 20:11:20, nick wrote: > > On ...
2 years, 10 months ago (2016-05-04 20:19:30 UTC) #9
Charlie Reis
LGTM
2 years, 10 months ago (2016-05-04 20:27:34 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1945173003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1945173003/40001
2 years, 10 months ago (2016-05-04 20:37:12 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
2 years, 10 months ago (2016-05-04 23:06:33 UTC) #14
commit-bot: I haz the power
2 years, 10 months ago (2016-05-04 23:08:34 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/470457d18d306a0f32ea548ad111371c24e509e1
Cr-Commit-Position: refs/heads/master@{#391678}

Powered by Google App Engine
This is Rietveld 408576698