Telemetry media Seek action and metrics.

Telemetry media Seek action and metrics.

BUG=249435
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213275

[shadi, 2013-07-19 01:33:35]

Adding media seek action. Pretty much it is similar to Play action except we can
have multiple seeks per page. 

PTAL

[dtu, 2013-07-20 01:20:56]

https://codereview.chromium.org/19482009/diff/5001/tools/telemetry/telemetry/...
File tools/telemetry/telemetry/page/actions/seek.js (right):

https://codereview.chromium.org/19482009/diff/5001/tools/telemetry/telemetry/...
tools/telemetry/telemetry/page/actions/seek.js:1: // Copyright (c) 2013 The
Chromium Authors. All rights reserved.
Can you reuse the code between the two JS files? Maybe just define both
__playMedia and __seekMedia in the same file.

https://codereview.chromium.org/19482009/diff/5001/tools/telemetry/telemetry/...
File tools/telemetry/telemetry/page/actions/seek.py (right):

https://codereview.chromium.org/19482009/diff/5001/tools/telemetry/telemetry/...
tools/telemetry/telemetry/page/actions/seek.py:39: if not hasattr(self,
'seek_time'):
assert this instead of raising PageActionFailed.

https://codereview.chromium.org/19482009/diff/5001/tools/telemetry/telemetry/...
tools/telemetry/telemetry/page/actions/seek.py:43:
tab.ExecuteJavaScript('window.__seekMedia(\'%s\', \'%s\', \'%s\');' %
" in place of \'

https://codereview.chromium.org/19482009/diff/5001/tools/telemetry/telemetry/...
File tools/telemetry/telemetry/page/actions/seek_unittest.py (right):

https://codereview.chromium.org/19482009/diff/5001/tools/telemetry/telemetry/...
tools/telemetry/telemetry/page/actions/seek_unittest.py:12: AUDIO_1_SEEKED_CHECK
= "window.__hasEventCompleted('#audio_1', 'seeked');"
Reverse single and double quotes.

https://codereview.chromium.org/19482009/diff/5001/tools/telemetry/telemetry/...
tools/telemetry/telemetry/page/actions/seek_unittest.py:21: '..', '..', '..',
'unittest_data')
util.GetUnittestDataDir()
It's new!! (sort of)

[tonyg, 2013-07-20 19:57:28]

lg2m when dave is happy.

https://codereview.chromium.org/19482009/diff/5001/tools/perf/perf_tools/medi...
File tools/perf/perf_tools/media_metrics.py (right):

https://codereview.chromium.org/19482009/diff/5001/tools/perf/perf_tools/medi...
tools/perf/perf_tools/media_metrics.py:47: def AddResult(metric, unit):
Should this be named AddResults now?

[shadi, 2013-07-22 19:18:31]

Thanks for reviews. PTAL

https://codereview.chromium.org/19482009/diff/5001/tools/perf/perf_tools/medi...
File tools/perf/perf_tools/media_metrics.py (right):

https://codereview.chromium.org/19482009/diff/5001/tools/perf/perf_tools/medi...
tools/perf/perf_tools/media_metrics.py:47: def AddResult(metric, unit):
On 2013/07/20 19:57:28, tonyg wrote:
> Should this be named AddResults now?
Yeah why not :)

https://codereview.chromium.org/19482009/diff/5001/tools/telemetry/telemetry/...
File tools/telemetry/telemetry/page/actions/seek.js (right):

https://codereview.chromium.org/19482009/diff/5001/tools/telemetry/telemetry/...
tools/telemetry/telemetry/page/actions/seek.js:1: // Copyright (c) 2013 The
Chromium Authors. All rights reserved.
On 2013/07/20 01:20:56, Dave Tu wrote:
> Can you reuse the code between the two JS files? Maybe just define both
> __playMedia and __seekMedia in the same file.
I went with a MediaAction base class that runs common JS and functions.

https://codereview.chromium.org/19482009/diff/5001/tools/telemetry/telemetry/...
File tools/telemetry/telemetry/page/actions/seek.py (right):

https://codereview.chromium.org/19482009/diff/5001/tools/telemetry/telemetry/...
tools/telemetry/telemetry/page/actions/seek.py:39: if not hasattr(self,
'seek_time'):
On 2013/07/20 01:20:56, Dave Tu wrote:
> assert this instead of raising PageActionFailed.

Done.

https://codereview.chromium.org/19482009/diff/5001/tools/telemetry/telemetry/...
tools/telemetry/telemetry/page/actions/seek.py:43:
tab.ExecuteJavaScript('window.__seekMedia(\'%s\', \'%s\', \'%s\');' %
On 2013/07/20 01:20:56, Dave Tu wrote:
> " in place of \'

Done.

https://codereview.chromium.org/19482009/diff/5001/tools/telemetry/telemetry/...
File tools/telemetry/telemetry/page/actions/seek_unittest.py (right):

https://codereview.chromium.org/19482009/diff/5001/tools/telemetry/telemetry/...
tools/telemetry/telemetry/page/actions/seek_unittest.py:12: AUDIO_1_SEEKED_CHECK
= "window.__hasEventCompleted('#audio_1', 'seeked');"
On 2013/07/20 01:20:56, Dave Tu wrote:
> Reverse single and double quotes.

Done.

https://codereview.chromium.org/19482009/diff/5001/tools/telemetry/telemetry/...
tools/telemetry/telemetry/page/actions/seek_unittest.py:21: '..', '..', '..',
'unittest_data')
On 2013/07/20 01:20:56, Dave Tu wrote:
> util.GetUnittestDataDir()
> It's new!! (sort of)

Done.

[dtu, 2013-07-22 21:57:19]

lgtm

[commit-bot: I haz the power, 2013-07-23 21:08:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/shadi@chromium.org/19482009/13001

[commit-bot: I haz the power, 2013-07-23 23:43:22]

Change committed as 213275