Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Unified Diff: tools/telemetry/telemetry/page/actions/play.js

Issue 19482009: Telemetry media Seek action and metrics. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add base media action class and JS code. Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/page/actions/play.js
diff --git a/tools/telemetry/telemetry/page/actions/play.js b/tools/telemetry/telemetry/page/actions/play.js
index eb174248e95b688325e9c5f62a5489ff55ec868a..ef3cb1b9af633dc3f08a1ca6697c92b825080afd 100644
--- a/tools/telemetry/telemetry/page/actions/play.js
+++ b/tools/telemetry/telemetry/page/actions/play.js
@@ -4,32 +4,9 @@
// This file performs actions on media elements.
(function() {
- function findMediaElements(selector) {
- // Returns elements matching the selector, otherwise returns the first video
- // or audio tag element that can be found.
- // If selector == 'all', returns all media elements.
- if (selector == 'all') {
- return document.querySelectorAll('video, audio');
- } else if (selector) {
- return document.querySelectorAll(selector);
- } else {
- var media = document.getElementsByTagName('video');
- if (media.length > 0) {
- return [media[0]];
- } else {
- media = document.getElementsByTagName('audio');
- if (media.length > 0) {
- return [media[0]];
- }
- }
- }
- console.error('Could not find any media elements matching: ' + selector);
- return [];
- }
-
function playMedia(selector) {
// Performs the "Play" action on media satisfying selector.
- var mediaElements = findMediaElements(selector);
+ var mediaElements = window.__findMediaElements(selector);
for (var i = 0; i < mediaElements.length; i++) {
console.log('Playing element: ' + mediaElements[i].src);
play(mediaElements[i]);
@@ -61,16 +38,5 @@
element.play();
}
- function hasEventCompleted(selector, event_name) {
- // Return true if the event_name fired for media satisfying the selector.
- var mediaElements = findMediaElements(selector);
- for (var i = 0; i < mediaElements.length; i++) {
- if (!mediaElements[i][event_name + '_completed'])
- return false;
- }
- return true;
- }
-
window.__playMedia = playMedia;
- window.__hasEventCompleted = hasEventCompleted;
})();
« no previous file with comments | « tools/telemetry/telemetry/page/actions/media_action.py ('k') | tools/telemetry/telemetry/page/actions/play.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698