Issue 19482004: Alter resource cache and GrContext to (optionally) never reuse a scratch texture

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19482004: Alter resource cache and GrContext to (optionally) never reuse a scratch texture (Closed)

Created:
7 years, 5 months ago by robertphillips

Modified:
7 years, 5 months ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Alter resource cache and GrContext to (optionally) never reuse a scratch texture

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+85 lines, -52 lines)			Patch
M	src/gpu/GrContext.cpp	View	1 2	6 chunks	+38 lines, -21 lines	0 comments	Download
M	src/gpu/GrResourceCache.h	View	1	7 chunks	+25 lines, -18 lines	0 comments	Download
M	src/gpu/GrResourceCache.cpp	View	1	4 chunks	+14 lines, -13 lines	0 comments	Download
M	src/gpu/gl/GrGLCaps.cpp	View	1 2	1 chunk	+8 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

robertphillips

This does make the test case we have render correctly on the N10.

7 years, 5 months ago (2013-07-19 13:06:58 UTC) #2

bsalomon

lgtm. I hope as we continue to (slowly) refactor the way refs and the cache ...

7 years, 5 months ago (2013-07-19 13:08:21 UTC) #3

robertphillips

7 years, 5 months ago (2013-07-19 16:52:21 UTC) #4

Message was sent while issue was closed.

Committed as r10193 but disabled it due to Android memory consumption issue.