Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: third_party/WebKit/LayoutTests/fast/dom/Geolocation/script-tests/delayed-permission-allowed.js

Issue 1948033003: Convert most geolocation layout tests to use a JS mock implementation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@permission-disconnect
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/fast/dom/Geolocation/script-tests/delayed-permission-allowed.js
diff --git a/third_party/WebKit/LayoutTests/fast/dom/Geolocation/script-tests/delayed-permission-allowed.js b/third_party/WebKit/LayoutTests/fast/dom/Geolocation/script-tests/delayed-permission-allowed.js
index 02c6e88921aafa3b94e34f1a2f43b27326ad4e9d..5fdb68f2cc72bd5408111d70e013f8020ba95270 100644
--- a/third_party/WebKit/LayoutTests/fast/dom/Geolocation/script-tests/delayed-permission-allowed.js
+++ b/third_party/WebKit/LayoutTests/fast/dom/Geolocation/script-tests/delayed-permission-allowed.js
@@ -1,30 +1,31 @@
description("Tests that when a position is available, no callbacks are invoked until permission is allowed.");
-if (!window.testRunner || !window.internals)
- debug('This test can not run without testRunner or internals');
+if (!window.testRunner || !window.mojo)
+ debug('This test can not run without testRunner or mojo');
-internals.setGeolocationClientMock(document);
-internals.setGeolocationPosition(document, 51.478, -0.166, 100);
+geolocationServiceMock.then(mock => {
+ mock.setGeolocationPosition(51.478, -0.166, 100);
-var permissionSet = false;
+ var permissionSet = false;
-function allowPermission() {
- permissionSet = true;
- internals.setGeolocationPermission(document, true);
-}
+ function allowPermission() {
+ permissionSet = true;
+ mock.setGeolocationPermission(true);
+ }
-navigator.geolocation.getCurrentPosition(function() {
- if (permissionSet) {
- testPassed('Success callback invoked');
+ navigator.geolocation.getCurrentPosition(function() {
+ if (permissionSet) {
+ testPassed('Success callback invoked');
+ finishJSTest();
+ return;
+ }
+ testFailed('Success callback invoked unexpectedly');
finishJSTest();
- return;
- }
- testFailed('Success callback invoked unexpectedly');
- finishJSTest();
-}, function() {
- testFailed('Error callback invoked unexpectedly');
- finishJSTest();
+ }, function() {
+ testFailed('Error callback invoked unexpectedly');
+ finishJSTest();
+ });
+ window.setTimeout(allowPermission, 100);
});
-window.setTimeout(allowPermission, 100);
window.jsTestIsAsync = true;

Powered by Google App Engine
This is Rietveld 408576698