Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Unified Diff: third_party/WebKit/LayoutTests/fast/dom/Geolocation/script-tests/clear-watch-invalid-id-crash.js

Issue 1948033003: Convert most geolocation layout tests to use a JS mock implementation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@permission-disconnect
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/fast/dom/Geolocation/script-tests/clear-watch-invalid-id-crash.js
diff --git a/third_party/WebKit/LayoutTests/fast/dom/Geolocation/script-tests/clear-watch-invalid-id-crash.js b/third_party/WebKit/LayoutTests/fast/dom/Geolocation/script-tests/clear-watch-invalid-id-crash.js
index 13fc8f44d69ea15e2bfa626aebe7e9677787dcce..3a98fade286a211109201957ada05e0a35cd1c25 100644
--- a/third_party/WebKit/LayoutTests/fast/dom/Geolocation/script-tests/clear-watch-invalid-id-crash.js
+++ b/third_party/WebKit/LayoutTests/fast/dom/Geolocation/script-tests/clear-watch-invalid-id-crash.js
@@ -1,16 +1,17 @@
description("Tests for a crash when clearWatch() is called with a zero ID.<br><br>We call clearWatch() with a request in progress then navigate the page. This accesses the watchers map during cleanup and triggers the crash. This page should not be visible when the test completes.");
-if (!window.testRunner || !window.internals)
- debug('This test can not run without testRunner or internals');
-
-internals.setGeolocationClientMock(document);
-internals.setGeolocationPermission(document, true);
-internals.setGeolocationPosition(document, 51.478, -0.166, 100);
+if (!window.testRunner || !window.mojo)
+ debug('This test can not run without testRunner or mojo');
document.body.onload = function() {
- navigator.geolocation.watchPosition(function() {});
- navigator.geolocation.clearWatch(0);
- location = "data:text/html,TEST COMPLETE<script>if(window.testRunner) testRunner.notifyDone();</script>";
+ geolocationServiceMock.then(mock => {
+ mock.setGeolocationPermission(true);
+ mock.setGeolocationPosition(51.478, -0.166, 100);
+
+ navigator.geolocation.watchPosition(function() {});
+ navigator.geolocation.clearWatch(0);
+ location = "data:text/html,TEST COMPLETE<script>if(window.testRunner) testRunner.notifyDone();</script>";
+ });
}
window.jsTestIsAsync = true;

Powered by Google App Engine
This is Rietveld 408576698