Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Unified Diff: recipe_engine/step_runner.py

Issue 1948023002: triggering: add critical flag (Closed) Base URL: git@github.com:luci/recipes-py.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: recipe_engine/step_runner.py
diff --git a/recipe_engine/step_runner.py b/recipe_engine/step_runner.py
index c4d166f9abc283ddd36ece58a27ecb81f8756d06..8e78b453dcaa955d0be349693eec1be7b7765f8b 100644
--- a/recipe_engine/step_runner.py
+++ b/recipe_engine/step_runner.py
@@ -43,9 +43,7 @@ class StepRunner(object):
cwd: absolute path to working directory for the command
env: dict with overrides for environment variables
allow_subannotations: if True, lets the step emit its own annotations
- trigger_specs: a list of trigger specifications, which are dict with keys:
- properties: a dict of properties.
- Buildbot requires buildername property.
+ trigger_specs: a list of trigger specifications, see also _trigger_builds.
stdout: Path to a file to put step stdout into. If used, stdout won't
appear in annotator's stdout (and |allow_subannotations| is
ignored).
@@ -337,6 +335,8 @@ class SubprocessStepRunner(StepRunner):
'builderNames': [builder_name],
'bucket': trig.get('bucket'),
'changes': changes,
+ # if True and triggering fails asynchronously, fail entire build.
nodir 2016/05/04 17:28:13 implemented in https://codereview.chromium.org/194
+ 'critical': trig.get('critical', True),
'properties': trig.get('properties'),
'tags': trig.get('tags'),
}, sort_keys=True))
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698