mojo/dart/packages/mojo/lib/src/codec.dart - Issue 1948003003: Dart: Wait to handle events on a Stub until it makes sense to do it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/dart/packages/mojo/lib/src/codec.dart

Issue 1948003003: Dart: Wait to handle events on a Stub until it makes sense to do it. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Add test Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/dart/packages/mojo/lib/src/codec.dart

diff --git a/mojo/dart/packages/mojo/lib/src/codec.dart b/mojo/dart/packages/mojo/lib/src/codec.dart

index 4e56f81a4c0ad6f7d3ba3093ce2432d2b0bd4f2f..092a9607026f2e75f1fe1323398761fe45ae1460 100644

--- a/mojo/dart/packages/mojo/lib/src/codec.dart

+++ b/mojo/dart/packages/mojo/lib/src/codec.dart

@@ -224,7 +224,6 @@ class Encoder {

}

var pipe = new core.MojoMessagePipe();

interface.bind(pipe.endpoints[0]);

- interface.beginHandlingEvents();

encodeMessagePipeHandle(pipe.endpoints[1], offset, nullable);

// Set the version to the version in the stub.

encodeUint32(interface.version, offset + kSerializedHandleSize);