mojo/dart/packages/mojo/lib/src/application_connection.dart - Issue 1948003003: Dart: Wait to handle events on a Stub until it makes sense to do it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/dart/packages/mojo/lib/src/application_connection.dart

Issue 1948003003: Dart: Wait to handle events on a Stub until it makes sense to do it. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Add test Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/dart/packages/mojo/lib/src/application_connection.dart

diff --git a/mojo/dart/packages/mojo/lib/src/application_connection.dart b/mojo/dart/packages/mojo/lib/src/application_connection.dart

index 2ade88d90d7d76a320e5f310cb5ad86702cf9e05..ad0dbb04694666bd27775f82cae8bd9188f52f30 100644

--- a/mojo/dart/packages/mojo/lib/src/application_connection.dart

+++ b/mojo/dart/packages/mojo/lib/src/application_connection.dart

@@ -13,10 +13,10 @@ class LocalServiceProvider implements ServiceProvider {

ServiceProviderStub _stub;

LocalServiceProvider(this.connection, this._stub) {

+ _stub.impl = this;

if (!_stub.isOpen) {

throw new core.MojoApiError("The service provider stub must be open");

}

- _stub.impl = this;

}

set onError(Function f) {