Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Issue 1947923004: [MD settings] separator line for side nav (Closed)

Created:
4 years, 7 months ago by dschuyler
Modified:
4 years, 7 months ago
Reviewers:
tommycli
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] separator line for side nav This CL adds a grey line between the Advanced menu section and the About Chrome in the side nav menu. (The bug has a screen shot of line and spacing). BUG=607611 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/1b838f3fc3fb41c43e69bc795394bad30a89b7f3 Cr-Commit-Position: refs/heads/master@{#392221}

Patch Set 1 #

Patch Set 2 : update from Alan #

Total comments: 4

Patch Set 3 : review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -4 lines) Patch
M chrome/browser/resources/settings/settings_menu/settings_menu.html View 1 2 4 chunks +15 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
dschuyler
4 years, 7 months ago (2016-05-04 23:43:59 UTC) #3
tommycli
https://codereview.chromium.org/1947923004/diff/20001/chrome/browser/resources/settings/settings_menu/settings_menu.html File chrome/browser/resources/settings/settings_menu/settings_menu.html (right): https://codereview.chromium.org/1947923004/diff/20001/chrome/browser/resources/settings/settings_menu/settings_menu.html#newcode71 chrome/browser/resources/settings/settings_menu/settings_menu.html:71: margin-top: 8px; Does it work if you put margin-bottom ...
4 years, 7 months ago (2016-05-06 18:23:48 UTC) #4
tommycli
On 2016/05/06 18:23:48, tommycli wrote: > https://codereview.chromium.org/1947923004/diff/20001/chrome/browser/resources/settings/settings_menu/settings_menu.html > File chrome/browser/resources/settings/settings_menu/settings_menu.html (right): > > https://codereview.chromium.org/1947923004/diff/20001/chrome/browser/resources/settings/settings_menu/settings_menu.html#newcode71 > ...
4 years, 7 months ago (2016-05-06 18:24:03 UTC) #5
dschuyler
https://codereview.chromium.org/1947923004/diff/20001/chrome/browser/resources/settings/settings_menu/settings_menu.html File chrome/browser/resources/settings/settings_menu/settings_menu.html (right): https://codereview.chromium.org/1947923004/diff/20001/chrome/browser/resources/settings/settings_menu/settings_menu.html#newcode71 chrome/browser/resources/settings/settings_menu/settings_menu.html:71: margin-top: 8px; On 2016/05/06 18:23:48, tommycli wrote: > Does ...
4 years, 7 months ago (2016-05-06 23:58:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1947923004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1947923004/40001
4 years, 7 months ago (2016-05-07 00:14:41 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-07 00:42:39 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-07 00:43:50 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/1b838f3fc3fb41c43e69bc795394bad30a89b7f3
Cr-Commit-Position: refs/heads/master@{#392221}

Powered by Google App Engine
This is Rietveld 408576698