[MD settings] separator line for side nav

[MD settings] separator line for side nav

This CL adds a grey line between the Advanced menu section and
the About Chrome in the side nav menu. (The bug has a screen shot
of line and spacing).

BUG=607611
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/1b838f3fc3fb41c43e69bc795394bad30a89b7f3
Cr-Commit-Position: refs/heads/master@{#392221}

[dschuyler, 2016-05-04 23:43:23]

Description was changed from

==========
[MD settings] separator line for side nav

This CL adds a grey line between the Advanced menu section and
the About Chrome in the side nav menu. (The bug has a screen shot
of line and spacing).

BUG=607611
==========

to

==========
[MD settings] separator line for side nav

This CL adds a grey line between the Advanced menu section and
the About Chrome in the side nav menu. (The bug has a screen shot
of line and spacing).

BUG=607611
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[dschuyler, 2016-05-04 23:43:58]

dschuyler@chromium.org changed reviewers:
+ tommycli@chromium.org

[tommycli, 2016-05-06 18:23:48]

https://codereview.chromium.org/1947923004/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/settings_menu/settings_menu.html (right):

https://codereview.chromium.org/1947923004/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/settings_menu/settings_menu.html:71:
margin-top: 8px;
Does it work if you put margin-bottom on every "paper-submenu div" rule?

https://codereview.chromium.org/1947923004/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/settings_menu/settings_menu.html:75:
border-bottom: 1px solid rgba(0, 0, 0, 0.08);
Alan really doesn't want to use the default --settings-separator-line here? If
so maybe add a comment calling this out as a special separator line.

If you follow the above suggestion (about the paper-submenu div rule) you might
need an extra margin on this element also, but I think that's more explicit.

[tommycli, 2016-05-06 18:24:03]

On 2016/05/06 18:23:48, tommycli wrote:
>
https://codereview.chromium.org/1947923004/diff/20001/chrome/browser/resource...
> File chrome/browser/resources/settings/settings_menu/settings_menu.html
(right):
> 
>
https://codereview.chromium.org/1947923004/diff/20001/chrome/browser/resource...
> chrome/browser/resources/settings/settings_menu/settings_menu.html:71:
> margin-top: 8px;
> Does it work if you put margin-bottom on every "paper-submenu div" rule?
> 
>
https://codereview.chromium.org/1947923004/diff/20001/chrome/browser/resource...
> chrome/browser/resources/settings/settings_menu/settings_menu.html:75:
> border-bottom: 1px solid rgba(0, 0, 0, 0.08);
> Alan really doesn't want to use the default --settings-separator-line here? If
> so maybe add a comment calling this out as a special separator line.
> 
> If you follow the above suggestion (about the paper-submenu div rule) you
might
> need an extra margin on this element also, but I think that's more explicit.

lgtm sans above nits

[dschuyler, 2016-05-06 23:58:24]

https://codereview.chromium.org/1947923004/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/settings_menu/settings_menu.html (right):

https://codereview.chromium.org/1947923004/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/settings_menu/settings_menu.html:71:
margin-top: 8px;
On 2016/05/06 18:23:48, tommycli wrote:
> Does it work if you put margin-bottom on every "paper-submenu div" rule?

Done.

https://codereview.chromium.org/1947923004/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/settings_menu/settings_menu.html:75:
border-bottom: 1px solid rgba(0, 0, 0, 0.08);
On 2016/05/06 18:23:48, tommycli wrote:
> Alan really doesn't want to use the default --settings-separator-line here? If
> so maybe add a comment calling this out as a special separator line.
> 
> If you follow the above suggestion (about the paper-submenu div rule) you
might
> need an extra margin on this element also, but I think that's more explicit.

Done.

[dschuyler, 2016-05-07 00:14:28]

The CQ bit was checked by dschuyler@chromium.org

[dschuyler, 2016-05-07 00:14:28]

The patchset sent to the CQ was uploaded after l-g-t-m from
tommycli@chromium.org
Link to the patchset: https://codereview.chromium.org/1947923004/#ps40001
(title: "review changes")

[commit-bot: I haz the power, 2016-05-07 00:14:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1947923004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1947923004/40001

[commit-bot: I haz the power, 2016-05-07 00:42:39]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-07 00:43:49]

Description was changed from

==========
[MD settings] separator line for side nav

This CL adds a grey line between the Advanced menu section and
the About Chrome in the side nav menu. (The bug has a screen shot
of line and spacing).

BUG=607611
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD settings] separator line for side nav

This CL adds a grey line between the Advanced menu section and
the About Chrome in the side nav menu. (The bug has a screen shot
of line and spacing).

BUG=607611
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/1b838f3fc3fb41c43e69bc795394bad30a89b7f3
Cr-Commit-Position: refs/heads/master@{#392221}
==========

[commit-bot: I haz the power, 2016-05-07 00:43:50]

Patchset 3 (id:??) landed as
https://crrev.com/1b838f3fc3fb41c43e69bc795394bad30a89b7f3
Cr-Commit-Position: refs/heads/master@{#392221}