Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2914)

Unified Diff: chrome/browser/resources/settings/settings_menu/settings_menu.html

Issue 1947923004: [MD settings] separator line for side nav (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review changes Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/settings_menu/settings_menu.html
diff --git a/chrome/browser/resources/settings/settings_menu/settings_menu.html b/chrome/browser/resources/settings/settings_menu/settings_menu.html
index 3c446fd2b1206231ce3b04fb7a97e2a80893706f..f4e62b0505a07c7fa3a1758f53a38d95a029c26c 100644
--- a/chrome/browser/resources/settings/settings_menu/settings_menu.html
+++ b/chrome/browser/resources/settings/settings_menu/settings_menu.html
@@ -33,15 +33,20 @@
}
paper-menu {
- background: none; /* Overrides <paper-menu> default. */
- color: var(--settings-nav-grey);
- font-size: 13px;
--paper-menu-selected-item: {
font-weight: 500;
};
--paper-menu-focused-item-after: {
background: none;
};
+ background: none; /* Overrides <paper-menu> default. */
+ color: var(--settings-nav-grey);
+ font-size: 13px;
+ padding: 0;
+ }
+
+ paper-submenu > div {
+ margin-top: 8px;
}
paper-submenu {
@@ -55,7 +60,6 @@
color: var(--google-blue-500);
font-weight: 500;
};
- padding: 0;
}
paper-submenu div {
@@ -66,6 +70,12 @@
font-weight: 500;
min-height: 40px;
}
+
+ .separator {
+ /* Per Alan@, this line is different from the other separator lines. */
+ border-bottom: 1px solid rgba(0, 0, 0, 0.08);
+ margin-top: 8px;
+ }
</style>
<paper-menu name="root-menu">
<paper-submenu data-page="basic" id="basicPage" opened="{{basicOpened_}}">
@@ -164,6 +174,7 @@
</div>
</paper-menu>
</paper-submenu>
+ <div class="separator"></div>
<paper-submenu data-page="about">
<div class="menu-trigger" on-tap="openPage_" data-section="">
<span i18n-content="aboutPageTitle"></span>
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698