components/cronet/ios/Info.plist - Issue 1947903003: Cronet Dynamic Framework for iOS

Side by Side Diff: components/cronet/ios/Info.plist

Issue 1947903003: Cronet Dynamic Framework for iOS (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added flag to package_ios.py that prepares Cronet dynamic framework Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <?xml version="1.0" encoding="UTF-8"?>	1 <?xml version="1.0" encoding="UTF-8"?>

2 <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/ PropertyList-1.0.dtd">	2 <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/ PropertyList-1.0.dtd">
	mef 2016/05/11 12:55:02 We should look into using infoplist_strings_tool, We should look into using infoplist_strings_tool, although it lives in chrome, so we may need to move it elsewhere. It should be fine to do in separate CL. kapishnikov 2016/05/11 19:48:15 Acknowledged. Show quoted text On 2016/05/11 12:55:02, mef wrote: > We should look into using infoplist_strings_tool, although it lives in chrome, > so we may need to move it elsewhere. > It should be fine to do in separate CL. Acknowledged.
3 <plist version="1.0">	3 <plist version="1.0">

4 <dict>	4 <dict>

5 <key>CFBundleDevelopmentRegion</key>	5 <key>CFBundleDevelopmentRegion</key>

6 » <string>English</string>	6 » <string>en</string>
	mef 2016/05/11 12:55:02 nit: tabs -> spaces? nit: tabs -> spaces? kapishnikov 2016/05/11 19:48:15 Done. Show quoted text On 2016/05/11 12:55:02, mef wrote: > nit: tabs -> spaces? Done.
7 <key>CFBundleExecutable</key>	7 <key>CFBundleExecutable</key>

8 » <string>${EXECUTABLE_NAME}</string>	8 » <string>Cronet</string>

9 » <key>CFBundleIconFile</key>

10 » <string></string>

11 <key>CFBundleIdentifier</key>	9 <key>CFBundleIdentifier</key>

12 » <string>com.mulle-kybernetik.${PRODUCT_NAME:rfc1034identifier}</string>	10 » <string>org.chromium.net.Cronet</string>

13 <key>CFBundleInfoDictionaryVersion</key>	11 <key>CFBundleInfoDictionaryVersion</key>

14 <string>6.0</string>	12 <string>6.0</string>

15 <key>CFBundleName</key>	13 <key>CFBundleName</key>

16 » <string>${PRODUCT_NAME}</string>	14 » <string>Cronet</string>

17 <key>CFBundlePackageType</key>	15 <key>CFBundlePackageType</key>

18 <string>FMWK</string>	16 <string>FMWK</string>

19 <key>CFBundleShortVersionString</key>	17 <key>CFBundleShortVersionString</key>

20 <string>1.0</string>	18 <string>1.0</string>

21 <key>CFBundleSignature</key>	19 <key>CFBundleSignature</key>

22 <string>????</string>	20 <string>????</string>

23 <key>CFBundleVersion</key>	21 <key>CFBundleVersion</key>

24 » <string>1</string>	22 » <string>1.0</string>

25 » <key>NSHumanReadableCopyright</key>
mef 2016/05/11 12:55:02 Put regular Chromium copyright? # Copyright 2014 Put regular Chromium copyright? # Copyright 2014 The Chromium Authors. All rights reserved. # Use of this source code is governed by a BSD-style license that can be # found in the LICENSE file. kapishnikov 2016/05/11 19:48:15 Done. Used one line copyright as other components Show quoted text On 2016/05/11 12:55:02, mef wrote: > Put regular Chromium copyright? > > # Copyright 2014 The Chromium Authors. All rights reserved. > # Use of this source code is governed by a BSD-style license that can be > # found in the LICENSE file. Done. Used one line copyright as other components do.
26 » <string>Copyright © 2004-2011 Mulle Kybernetik.</string>

27 <key>NSPrincipalClass</key>	23 <key>NSPrincipalClass</key>

28 <string></string>	24 <string></string>

29 </dict>	25 </dict>

30 </plist>	26 </plist>

OLD	NEW

« no previous file with comments | « components/cronet/ios/Cronet.mm ('k') | components/cronet/ios/empty.cc » ('j') | components/cronet/ios/empty.cc » ('J')