Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 1947843002: X87: [Atomics] Fix disassembly for ia32 xchg_b and xchg_w. (Closed)

Created:
4 years, 7 months ago by zhengxing.li
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [Atomics] Fix disassembly for ia32 xchg_b and xchg_w. port af677d7b34df41c6e65558a925b2b33398b38c30 (r35998) original commit message: https://codereview.chromium.org/1938213002 added xchg_b and xchg_w, but didn't add it to the disassembler, and there were no tests that caught it. BUG= Committed: https://crrev.com/e8c7592c5e01aac31960956b1358f2c39119c9ec Cr-Commit-Position: refs/heads/master@{#36051}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -12 lines) Patch
M src/x87/disasm-x87.cc View 2 chunks +20 lines, -12 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 7 months ago (2016-05-04 05:44:33 UTC) #2
Weiliang
lgtm
4 years, 7 months ago (2016-05-05 02:06:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1947843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1947843002/1
4 years, 7 months ago (2016-05-05 03:23:29 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-05 19:06:31 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-05 19:07:58 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e8c7592c5e01aac31960956b1358f2c39119c9ec
Cr-Commit-Position: refs/heads/master@{#36051}

Powered by Google App Engine
This is Rietveld 408576698