Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1947773002: Fix all strong-mode warnings. (Closed)

Created:
4 years, 7 months ago by nweiz
Modified:
4 years, 7 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/barback@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix all strong-mode warnings. This would be cleaner if we could use async/await, but unfortunately Barback is extremely sensitive to asynchronous gaps so adding microtask waits at the beginning of methods causes a bunch of tests to fail. R=rnystrom@google.com Committed: https://github.com/dart-lang/barback/commit/c08f27b493165056ada88c0870d767b5d0950dc4

Patch Set 1 #

Patch Set 2 : cleaner workarounds #

Total comments: 2

Patch Set 3 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+191 lines, -184 lines) Patch
A .analysis_options View 1 chunk +2 lines, -0 lines 0 comments Download
M CHANGELOG.md View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M lib/src/asset/asset_node.dart View 2 chunks +3 lines, -4 lines 0 comments Download
M lib/src/asset/asset_set.dart View 1 chunk +1 line, -4 lines 0 comments Download
M lib/src/asset/internal_asset.dart View 3 chunks +10 lines, -4 lines 0 comments Download
M lib/src/build_result.dart View 1 chunk +3 lines, -1 line 0 comments Download
M lib/src/errors.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M lib/src/graph/asset_cascade.dart View 4 chunks +6 lines, -5 lines 0 comments Download
M lib/src/graph/group_runner.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/graph/package_graph.dart View 4 chunks +7 lines, -6 lines 0 comments Download
M lib/src/graph/phase.dart View 5 chunks +8 lines, -5 lines 0 comments Download
M lib/src/graph/static_asset_cascade.dart View 3 chunks +7 lines, -4 lines 0 comments Download
M lib/src/graph/transform_node.dart View 4 chunks +5 lines, -3 lines 0 comments Download
M lib/src/graph/transformer_classifier.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M lib/src/transformer/aggregate_transform.dart View 6 chunks +10 lines, -6 lines 0 comments Download
M lib/src/transformer/base_transform.dart View 2 chunks +1 line, -3 lines 0 comments Download
M lib/src/transformer/declaring_aggregate_transform.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M lib/src/transformer/wrapping_aggregate_transformer.dart View 2 chunks +1 line, -2 lines 0 comments Download
M lib/src/utils.dart View 1 9 chunks +39 lines, -28 lines 0 comments Download
M lib/src/utils/cancelable_future.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M lib/src/utils/file_pool.dart View 2 chunks +1 line, -2 lines 0 comments Download
M lib/src/utils/multiset.dart View 2 chunks +5 lines, -4 lines 0 comments Download
M pubspec.yaml View 2 chunks +4 lines, -3 lines 0 comments Download
M test/transformer/aggregate_many_to_one.dart View 1 chunk +8 lines, -9 lines 0 comments Download
M test/transformer/declaring_check_content_and_rename.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/transformer/lazy_check_content_and_rename.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/transformer/many_to_one.dart View 1 chunk +17 lines, -18 lines 0 comments Download
M test/transformer/mock.dart View 2 chunks +7 lines, -12 lines 0 comments Download
M test/transformer/mock_aggregate.dart View 2 chunks +7 lines, -12 lines 0 comments Download
M test/transformer/one_to_many.dart View 1 chunk +6 lines, -9 lines 0 comments Download
M test/transformer/sync_rewrite.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/utils.dart View 1 2 8 chunks +19 lines, -23 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
nweiz
4 years, 7 months ago (2016-05-03 22:05:57 UTC) #1
Bob Nystrom
lgtm https://codereview.chromium.org/1947773002/diff/20001/test/utils.dart File test/utils.dart (right): https://codereview.chromium.org/1947773002/diff/20001/test/utils.dart#newcode537 test/utils.dart:537: var assetMap = mapMapValues/*<String, List<Asset>, AssetSet>*/( Does the ...
4 years, 7 months ago (2016-05-13 21:07:50 UTC) #2
nweiz
Code review changes
4 years, 7 months ago (2016-05-17 17:27:39 UTC) #3
nweiz
https://codereview.chromium.org/1947773002/diff/20001/test/utils.dart File test/utils.dart (right): https://codereview.chromium.org/1947773002/diff/20001/test/utils.dart#newcode537 test/utils.dart:537: var assetMap = mapMapValues/*<String, List<Asset>, AssetSet>*/( On 2016/05/13 21:07:50, ...
4 years, 7 months ago (2016-05-17 17:27:46 UTC) #4
nweiz
4 years, 7 months ago (2016-05-17 17:30:02 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
c08f27b493165056ada88c0870d767b5d0950dc4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698