Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(639)

Unified Diff: lib/src/utils/cancelable_future.dart

Issue 1947773002: Fix all strong-mode warnings. (Closed) Base URL: git@github.com:dart-lang/barback@master
Patch Set: Code review changes Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/utils.dart ('k') | lib/src/utils/file_pool.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/utils/cancelable_future.dart
diff --git a/lib/src/utils/cancelable_future.dart b/lib/src/utils/cancelable_future.dart
index 64d2b5fa203e4eb9c98a7039a504325adfb7ccbc..35bfdf5daaee84f39c91ec6f98929daa0d7b10f0 100644
--- a/lib/src/utils/cancelable_future.dart
+++ b/lib/src/utils/cancelable_future.dart
@@ -27,12 +27,12 @@ class CancelableFuture<T> implements Future<T> {
}
Stream<T> asStream() => _completer.future.asStream();
- Future catchError(Function onError, {bool test(error)}) =>
+ Future catchError(Function onError, {bool test(Object error)}) =>
_completer.future.catchError(onError, test: test);
- Future then(onValue(T value), {Function onError}) =>
+ Future/*<S>*/ then/*<S>*/(/*=S*/ onValue(T value), {Function onError}) =>
_completer.future.then(onValue, onError: onError);
Future<T> whenComplete(action()) => _completer.future.whenComplete(action);
- Future timeout(Duration timeLimit, {void onTimeout()}) =>
+ Future<T> timeout(Duration timeLimit, {void onTimeout()}) =>
_completer.future.timeout(timeLimit, onTimeout: onTimeout);
/// Cancels this future.
void cancel() {
« no previous file with comments | « lib/src/utils.dart ('k') | lib/src/utils/file_pool.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698