Early terminate WebGL markContextChanged calls when appropriate.

Early terminate WebGL markContextChanged calls when appropriate.

BUG=608873
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

[bajones, 2016-05-03 22:02:24]

Description was changed from

==========
Early terminate WebGL markContextChanged calls when appropriate.

BUG=608873
==========

to

==========
Early terminate WebGL markContextChanged calls when appropriate.

BUG=608873
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[bajones, 2016-05-03 22:06:27]

bajones@chromium.org changed reviewers:
+ kbr@chromium.org, vmiura@chromium.org

[bajones, 2016-05-03 22:06:27]

Had the DrawingBuffer markContextChanged return true when it's not a redundant
call. Tracking in the WebGLRenderingContextBase is tricky because not all
rendering paths notify the context when a frame is produced, so it's context
changed flag is never reset in some cases.

[Ken Russell (switch to Gerrit), 2016-05-03 22:11:43]

Is a performance difference visible on the affected test from
http://crbug.com/608873 ?

Regardless, could you please extract the spinning triangle test from the
Animometer WebGL test, change it to run a fixed number of triangles for a fixed
duration of time, and add it to the tough_webgl_cases page set on the perf bots?
Without performance tracking this will surely regress again.

[Ken Russell (switch to Gerrit), 2016-05-16 19:05:24]

Now that the test is on the Perf waterfall, and the speedup to
preserveObjectWrapper in https://codereview.chromium.org/1974713003/ is visible:

https://chromeperf.appspot.com/report?sid=1c4e684a906366fd16022caa6f42fbf224b...

let's proceed with this CL. LGTM

https://codereview.chromium.org/1947763002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.h (right):

https://codereview.chromium.org/1947763002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.h:156: bool
markContentsChanged();
Please document the return value.

[bajones, 2016-05-17 22:32:19]

The CQ bit was checked by bajones@chromium.org

[bajones, 2016-05-17 22:32:19]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org
Link to the patchset: https://codereview.chromium.org/1947763002/#ps20001
(title: "Documented return value of markContentsChanged")

[commit-bot: I haz the power, 2016-05-17 22:33:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1947763002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1947763002/20001

[commit-bot: I haz the power, 2016-05-17 23:33:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-17 23:33:44]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[bajones1, 2016-06-01 17:25:10]

The CQ bit was checked by bajones@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-06-01 17:25:36]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1947763002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1947763002/40001

[commit-bot: I haz the power, 2016-06-01 19:14:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-01 19:14:20]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[vmiura, 2016-10-05 23:44:53]

kbr: Did a fix get landed for this elsewhere?  Do we need a new owner?

[Ken Russell (switch to Gerrit), 2016-10-06 00:01:43]

On 2016/10/05 23:44:53, vmiura wrote:
> kbr: Did a fix get landed for this elsewhere?  Do we need a new owner?

It didn't get landed -- yes, a new owner is needed.