third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp - Issue 1947763002: Early terminate WebGL markContextChanged calls when appropriate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp

Issue 1947763002: Early terminate WebGL markContextChanged calls when appropriate. Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and minor logic tweak to fix tests Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp

diff --git a/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp b/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp

index 70d454fe26280c8b1fb0f5a6742bb196a21fb48d..5d8f9fa850b421c9f7e2153e4cb0b178e9df7f1e 100644

--- a/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp

+++ b/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp

@@ -1170,7 +1170,8 @@ void WebGLRenderingContextBase::markContextChanged(ContentChangeType changeType)

if (m_framebufferBinding || isContextLost())

return;

- drawingBuffer()->markContentsChanged();

+ if (m_markedCanvasDirty && !drawingBuffer()->markContentsChanged())

+ return;

if (!canvas())

return;

« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.h » ('j') | no next file with comments »