cc : Add subtree is hidden bool to effect tree

cc : Add subtree hidden bool to effect tree

This is required for making the property tree sync at commit time
independant of layer properties. Adding it to the effect tree also
makes it possible to delete LayerImpl::hide_layer_and_subtree. I have
deleted it and added it to LayerImplTestProperties for tests.

BUG=609205
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/5121caa8626ab6991b4a751d0aa5ee8be244e4b9
Cr-Commit-Position: refs/heads/master@{#391809}

[jaydasika, 2016-05-05 00:39:43]

Description was changed from

==========
cc : Add subtree hidden bool to effect tree

This is required for making the property tree sync at commit time
independant of layer properties. Adding it to the effect tree also
makes it possible to delete LayerImpl::hide_layer_and_subtree. I have
deleted it and added it to LayerImplTestProperties for tests.

BUG=609205
==========

to

==========
cc : Add subtree hidden bool to effect tree

This is required for making the property tree sync at commit time
independant of layer properties. Adding it to the effect tree also
makes it possible to delete LayerImpl::hide_layer_and_subtree. I have
deleted it and added it to LayerImplTestProperties for tests.

BUG=609205
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[jaydasika, 2016-05-05 00:43:46]

jaydasika@chromium.org changed reviewers:
+ ajuma@chromium.org, vollick@chromium.org, weiliangc@chromium.org

[jaydasika, 2016-05-05 00:43:47]

PTAL

[Ian Vollick, 2016-05-05 12:03:13]

Seems pretty straightforward. lgtm % fixes mentioned below.

https://codereview.chromium.org/1947683007/diff/20001/cc/trees/property_tree_...
File cc/trees/property_tree_builder.cc (right):

https://codereview.chromium.org/1947683007/diff/20001/cc/trees/property_tree_...
cc/trees/property_tree_builder.cc:679: static inline float
HideLayerAndSubtree(Layer* layer) {
bool?

https://codereview.chromium.org/1947683007/diff/20001/cc/trees/property_tree_...
cc/trees/property_tree_builder.cc:683: static inline float
HideLayerAndSubtree(LayerImpl* layer) {
bool?

[jaydasika, 2016-05-05 14:28:28]

https://codereview.chromium.org/1947683007/diff/20001/cc/trees/property_tree_...
File cc/trees/property_tree_builder.cc (right):

https://codereview.chromium.org/1947683007/diff/20001/cc/trees/property_tree_...
cc/trees/property_tree_builder.cc:679: static inline float
HideLayerAndSubtree(Layer* layer) {
On 2016/05/05 12:03:13, vollick wrote:
> bool?

Done.

https://codereview.chromium.org/1947683007/diff/20001/cc/trees/property_tree_...
cc/trees/property_tree_builder.cc:683: static inline float
HideLayerAndSubtree(LayerImpl* layer) {
On 2016/05/05 12:03:13, vollick wrote:
> bool?

Done.

[jaydasika, 2016-05-05 14:28:34]

The CQ bit was checked by jaydasika@chromium.org

[jaydasika, 2016-05-05 14:28:35]

The patchset sent to the CQ was uploaded after l-g-t-m from vollick@chromium.org
Link to the patchset: https://codereview.chromium.org/1947683007/#ps40001
(title: " ")

[commit-bot: I haz the power, 2016-05-05 14:28:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1947683007/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1947683007/40001

[commit-bot: I haz the power, 2016-05-05 15:43:45]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-05 15:44:51]

Description was changed from

==========
cc : Add subtree hidden bool to effect tree

This is required for making the property tree sync at commit time
independant of layer properties. Adding it to the effect tree also
makes it possible to delete LayerImpl::hide_layer_and_subtree. I have
deleted it and added it to LayerImplTestProperties for tests.

BUG=609205
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc : Add subtree hidden bool to effect tree

This is required for making the property tree sync at commit time
independant of layer properties. Adding it to the effect tree also
makes it possible to delete LayerImpl::hide_layer_and_subtree. I have
deleted it and added it to LayerImplTestProperties for tests.

BUG=609205
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/5121caa8626ab6991b4a751d0aa5ee8be244e4b9
Cr-Commit-Position: refs/heads/master@{#391809}
==========

[commit-bot: I haz the power, 2016-05-05 15:44:52]

Patchset 3 (id:??) landed as
https://crrev.com/5121caa8626ab6991b4a751d0aa5ee8be244e4b9
Cr-Commit-Position: refs/heads/master@{#391809}