Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 1947673002: [Atomics] Fix disassembly for ia32 xchg_b and xchg_w (Closed)

Created:
4 years, 7 months ago by binji
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Atomics] Fix disassembly for ia32 xchg_b and xchg_w https://codereview.chromium.org/1938213002 added xchg_b and xchg_w, but didn't add it to the disassembler, and there were no tests that caught it. BUG=v8:4614 TBR=bmeurer@chromium.org LOG=n Committed: https://crrev.com/af677d7b34df41c6e65558a925b2b33398b38c30 Cr-Commit-Position: refs/heads/master@{#35998}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -12 lines) Patch
M src/ia32/disasm-ia32.cc View 2 chunks +20 lines, -12 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
binji
4 years, 7 months ago (2016-05-03 19:05:14 UTC) #3
Dan Ehrenberg
lgtm This code looks reasonable to me, but it's not my main area. It is ...
4 years, 7 months ago (2016-05-03 19:05:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1947673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1947673002/1
4 years, 7 months ago (2016-05-03 19:10:03 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-03 19:58:26 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/af677d7b34df41c6e65558a925b2b33398b38c30 Cr-Commit-Position: refs/heads/master@{#35998}
4 years, 7 months ago (2016-05-03 20:00:44 UTC) #12
Benedikt Meurer
4 years, 7 months ago (2016-05-04 05:42:00 UTC) #13
Message was sent while issue was closed.
LGTM.

Powered by Google App Engine
This is Rietveld 408576698