Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(608)

Issue 1947643002: Revert of Turn on assert_no_deps for blink in browser (Closed)

Created:
4 years, 7 months ago by scottmg
Modified:
4 years, 7 months ago
Reviewers:
brettw
CC:
chromium-reviews, darin-cc_chromium.org, gcasto+watchlist_chromium.org, jam, vabr+watchlistpasswordmanager_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Turn on assert_no_deps for blink in browser (patchset #2 id:20001 of https://codereview.chromium.org/1926443002/ ) Reason for revert: debug static linux is sadness. BUG=608114 and others. Original issue's description: > Turn on assert_no_deps for blink in browser > > R=brettw@chromium.org > BUG=582206 > > Committed: https://crrev.com/ffb95be04fb4effb750884083cb1c166c5499b7a > Cr-Commit-Position: refs/heads/master@{#390123} TBR=brettw@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=582206 Committed: https://crrev.com/8a6abb71c16674052eec28cff8d16d15fda4577b Cr-Commit-Position: refs/heads/master@{#391314}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M chrome/BUILD.gn View 1 chunk +3 lines, -1 line 0 comments Download
M components/password_manager/content/public/cpp/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/BUILD.gn View 1 chunk +5 lines, -0 lines 0 comments Download
M content/common/BUILD.gn View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (2 generated)
scottmg
Created Revert of Turn on assert_no_deps for blink in browser
4 years, 7 months ago (2016-05-03 17:30:46 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1947643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1947643002/1
4 years, 7 months ago (2016-05-03 17:31:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1947643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1947643002/1
4 years, 7 months ago (2016-05-03 17:32:10 UTC) #3
brettw
Can you reland and set it only when for the release static or debug component ...
4 years, 7 months ago (2016-05-03 18:01:54 UTC) #4
brettw
lgtm
4 years, 7 months ago (2016-05-03 18:01:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1947643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1947643002/1
4 years, 7 months ago (2016-05-03 18:02:19 UTC) #6
scottmg
On 2016/05/03 18:01:54, brettw wrote: > Can you reland and set it only when for ...
4 years, 7 months ago (2016-05-03 18:13:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1947643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1947643002/1
4 years, 7 months ago (2016-05-03 18:31:38 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-03 18:50:39 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 18:51:52 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8a6abb71c16674052eec28cff8d16d15fda4577b
Cr-Commit-Position: refs/heads/master@{#391314}

Powered by Google App Engine
This is Rietveld 408576698