chrome/BUILD.gn - Issue 1947643002: Revert of Turn on assert_no_deps for blink in browser

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/BUILD.gn

Issue 1947643002: Revert of Turn on assert_no_deps for blink in browser (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/BUILD.gn

diff --git a/chrome/BUILD.gn b/chrome/BUILD.gn

index 3109d77ba870fe1c67aa33cdb8785431a5e5b7f4..d805bff22fffcb04196fe83fe7179254d9028d0e 100644

--- a/chrome/BUILD.gn

+++ b/chrome/BUILD.gn

@@ -474,7 +474,9 @@

# build this is OK because all of content is linked into one library.

# Note that the blink_headers target is OK, so we can't do a wildcard for

# all blink targets.

- "//third_party/WebKit/public:blink",

+ # TODO(brettw) bug 582206: Blink should not be linked into the browser

+ # process, and then we can enable this.

+ #"//third_party/WebKit/public:blink",

# TODO(brettw) bug 581766: V8 should not be linked into the browser

# process, and then we can enable this.

#"//v8/*",

« no previous file with comments | « no previous file | components/password_manager/content/public/cpp/BUILD.gn » ('j') | no next file with comments »