Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1947543002: Make GrStyle more sk_sp savy (Closed)

Created:
4 years, 7 months ago by bsalomon
Modified:
4 years, 7 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M src/gpu/GrStyle.h View 3 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/GrStyle.cpp View 3 chunks +3 lines, -3 lines 0 comments Download

Dependent Patchsets:

Issue 1951613002 Patch 1
Issue 1951613002 Patch 20001

Messages

Total messages: 9 (4 generated)
bsalomon
4 years, 7 months ago (2016-05-03 15:38:34 UTC) #3
robertphillips
lgtm
4 years, 7 months ago (2016-05-03 15:40:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1947543002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1947543002/1
4 years, 7 months ago (2016-05-03 16:20:46 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/46db22f1cfc65a7a4f1de13d774718347362f60f
4 years, 7 months ago (2016-05-03 16:31:47 UTC) #8
bsalomon
4 years, 7 months ago (2016-05-03 17:11:48 UTC) #9
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1943973002/ by bsalomon@google.com.

The reason for reverting is: Crashing Ubuntu/GCC bot (but not clang).

Powered by Google App Engine
This is Rietveld 408576698