Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issue 1947423004: Simplify HTMLProgressElement::didElementStateChange. (Closed)

Created:
4 years, 7 months ago by tkent
Modified:
4 years, 7 months ago
Reviewers:
kochi
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify HTMLProgressElement::didElementStateChange. We can invalidate |:indeterminate| selector in parseAttribute(). Note that isDeterminate() is equivalent to fastHasAttribute(valueAttr). This CL reduces dependency from HTMLProgressElement to LayoutProgress. This CL has no behavior changes. BUG=609687 Committed: https://crrev.com/9e63af3fae3962ddef32adde079fae2784085182 Cr-Commit-Position: refs/heads/master@{#392011}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M third_party/WebKit/Source/core/html/HTMLProgressElement.cpp View 2 chunks +7 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
tkent
kochi@, would you review this please?
4 years, 7 months ago (2016-05-06 04:21:20 UTC) #4
kochi
lgtm
4 years, 7 months ago (2016-05-06 04:49:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1947423004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1947423004/1
4 years, 7 months ago (2016-05-06 05:21:42 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-06 06:00:45 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-06 06:02:02 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9e63af3fae3962ddef32adde079fae2784085182
Cr-Commit-Position: refs/heads/master@{#392011}

Powered by Google App Engine
This is Rietveld 408576698