Simplify HTMLProgressElement::didElementStateChange.

third_party/WebKit/Source/core/html/HTMLProgressElement.cpp

 /*
  * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 57 matching lines @@
     if (layoutObject() && layoutObject()->isProgress())
         return toLayoutProgress(layoutObject());
 
     LayoutObject* layoutObject = userAgentShadowRoot()->firstChild()->layoutObject();
     ASSERT_WITH_SECURITY_IMPLICATION(!layoutObject || layoutObject->isProgress());
     return toLayoutProgress(layoutObject);
 }
 
 void HTMLProgressElement::parseAttribute(const QualifiedName& name, const AtomicString& oldValue, const AtomicString& value)
 {
-    if (name == valueAttr)
+    if (name == valueAttr) {
+        if (oldValue.isNull() != value.isNull())
+            pseudoStateChanged(CSSSelector::PseudoIndeterminate);
         didElementStateChange();
-    else if (name == maxAttr)
+    } else if (name == maxAttr) {
         didElementStateChange();
-    else
+    } else {
         LabelableElement::parseAttribute(name, oldValue, value);
+    }
 }
 
 void HTMLProgressElement::attach(const AttachContext& context)
 {
     LabelableElement::attach(context);
     if (LayoutProgressItem layoutItem = LayoutProgressItem(layoutProgress()))
         layoutItem.updateFromElement();
 }
 
 double HTMLProgressElement::value() const
@@ skipping 35 matching lines @@
 }
 
 bool HTMLProgressElement::isDeterminate() const
 {
     return fastHasAttribute(valueAttr);
 }
 
 void HTMLProgressElement::didElementStateChange()
 {
     m_value->setWidthPercentage(position() * 100);
-    if (LayoutProgressItem layoutItem = LayoutProgressItem(layoutProgress())) {
-        bool wasDeterminate = layoutItem.isDeterminate();
+    if (LayoutProgressItem layoutItem = LayoutProgressItem(layoutProgress()))
         layoutItem.updateFromElement();
-        if (wasDeterminate != isDeterminate())
-            pseudoStateChanged(CSSSelector::PseudoIndeterminate);
-    }
 }
 
 void HTMLProgressElement::didAddUserAgentShadowRoot(ShadowRoot& root)
 {
     ASSERT(!m_value);
 
     ProgressInnerElement* inner = ProgressInnerElement::create(document());
     inner->setShadowPseudoId(AtomicString("-webkit-progress-inner-element"));
     root.appendChild(inner);
 
@@ skipping 13 matching lines @@
     return !isDeterminate();
 }
 
 DEFINE_TRACE(HTMLProgressElement)
 {
     visitor->trace(m_value);
     LabelableElement::trace(visitor);
 }
 
 } // namespace blink