Issue 1947283005: [merge-m51] RenderTextMac: Invoke SkiaTextRenderer::SetFontRenderParams()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1947283005: [merge-m51] RenderTextMac: Invoke SkiaTextRenderer::SetFontRenderParams() (Closed)

Created:
4 years, 7 months ago by tapted

Modified:
4 years, 7 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2704

Target Ref:
refs/pending/branch-heads/2704

Project:
chromium

Visibility:
Public.

[merge-m51] RenderTextMac: Invoke SkiaTextRenderer::SetFontRenderParams() RenderTextMac currently doesn't invoke SetFontRenderParams which means parameters such as RenderText::subpixel_rendering_suppressed() do not propagate. BUG=608575 Review-Url: https://codereview.chromium.org/1941293002 Cr-Commit-Position: refs/heads/master@{#391452} (cherry picked from commit 63254c155cad73e88e113887f2646603f96986f8) Committed: https://chromium.googlesource.com/chromium/src/+/bdac52255fe138f03da71919824f7a606b1ab2fe

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	ui/gfx/render_text_harfbuzz.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	ui/gfx/render_text_mac.mm	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

tapted

4 years, 7 months ago (2016-05-06 01:02:43 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
bdac52255fe138f03da71919824f7a606b1ab2fe.