Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(695)

Issue 1941293002: RenderTextMac: Invoke SkiaTextRenderer::SetFontRenderParams() (Closed)

Created:
4 years, 7 months ago by tapted
Modified:
4 years, 7 months ago
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

RenderTextMac: Invoke SkiaTextRenderer::SetFontRenderParams() RenderTextMac currently doesn't invoke SetFontRenderParams which means parameters such as RenderText::subpixel_rendering_suppressed() do not propagate. BUG=608575 Committed: https://crrev.com/63254c155cad73e88e113887f2646603f96986f8 Cr-Commit-Position: refs/heads/master@{#391452}

Patch Set 1 #

Patch Set 2 : Fix linux #

Patch Set 3 : Rebase? #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -7 lines) Patch
M ui/gfx/render_text_harfbuzz.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M ui/gfx/render_text_mac.mm View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/gfx/render_text_unittest.cc View 1 3 chunks +49 lines, -7 lines 0 comments Download

Messages

Total messages: 23 (14 generated)
tapted
Hi Alexei, please take a look
4 years, 7 months ago (2016-05-03 05:39:45 UTC) #6
Alexei Svitkine (slow)
lgtm
4 years, 7 months ago (2016-05-03 14:54:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1941293002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1941293002/40001
4 years, 7 months ago (2016-05-03 23:33:09 UTC) #9
commit-bot: I haz the power
Failed to apply the patch.
4 years, 7 months ago (2016-05-04 00:20:38 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1941293002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1941293002/60001
4 years, 7 months ago (2016-05-04 04:26:56 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/164819)
4 years, 7 months ago (2016-05-04 04:48:08 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1941293002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1941293002/60001
4 years, 7 months ago (2016-05-04 04:51:08 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 7 months ago (2016-05-04 05:37:23 UTC) #21
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 05:38:58 UTC) #23
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/63254c155cad73e88e113887f2646603f96986f8
Cr-Commit-Position: refs/heads/master@{#391452}

Powered by Google App Engine
This is Rietveld 408576698