Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1947283003: [Merge to M51] Don't show the 'wallpaper-set-by-message' if the current wallpaper is set by the rig… (Closed)

Created:
4 years, 7 months ago by xdai1
Modified:
4 years, 7 months ago
Reviewers:
bshe
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

[Merge to M51] Don't show the 'wallpaper-set-by-message' if the current wallpaper is set by the right click menu of Files App. Setting wallpaper from right click menu in 'Files' app is a feature that was implemented in crbug.com/578935. Since 'Files' app is a built-in v1 app in ChromeOS, we should treat it slightly differently with other third party apps: the wallpaper set by the 'Files' app should still be syncable and it should not appear in the wallpaper grid in the Wallpaper Picker. But we should not display the 'wallpaper-set-by-mesage' since it might introduce confusion as shown in crbug.com/599407. BUG=599407 TBR=bshe@chromium.org Review-Url: https://codereview.chromium.org/1931713002 Cr-Commit-Position: refs/heads/master@{#391098} (cherry picked from commit ddd4b8e014ac5c63e4447a5f6631521bf13819e8) Committed: https://chromium.googlesource.com/chromium/src/+/347945a930183408d74eb6681916b39be82e6ecf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -2 lines) Patch
M chrome/browser/chromeos/extensions/wallpaper_api.cc View 3 chunks +15 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
xdai1
4 years, 7 months ago (2016-05-05 17:32:39 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
347945a930183408d74eb6681916b39be82e6ecf (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698