Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1931713002: Don't show the 'wallpaper-set-by-message' if the current wallpaper is set by the right click menu o… (Closed)

Created:
4 years, 7 months ago by xdai1
Modified:
4 years, 7 months ago
Reviewers:
bshe
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't show the 'wallpaper-set-by-message' if the current wallpaper is set by the right click menu of Files App. Setting wallpaper from right click menu in 'Files' app is a feature that was implemented in crbug.com/578935. Since 'Files' app is a built-in v1 app in ChromeOS, we should treat it slightly differently with other third party apps: the wallpaper set by the 'Files' app should still be syncable and it should not appear in the wallpaper grid in the Wallpaper Picker. But we should not display the 'wallpaper-set-by-mesage' since it might introduce confusion as shown in crbug.com/599407. BUG=599407 Committed: https://crrev.com/ddd4b8e014ac5c63e4447a5f6631521bf13819e8 Cr-Commit-Position: refs/heads/master@{#391098}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -2 lines) Patch
M chrome/browser/chromeos/extensions/wallpaper_api.cc View 3 chunks +15 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
xdai1
Biao, could you help review this CL please? Thanks!
4 years, 7 months ago (2016-04-28 00:17:01 UTC) #2
bshe
On 2016/04/28 00:17:01, xdai1 wrote: > Biao, could you help review this CL please? Thanks! ...
4 years, 7 months ago (2016-04-29 20:48:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1931713002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1931713002/1
4 years, 7 months ago (2016-05-02 22:52:07 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-02 23:37:23 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-02 23:38:41 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ddd4b8e014ac5c63e4447a5f6631521bf13819e8
Cr-Commit-Position: refs/heads/master@{#391098}

Powered by Google App Engine
This is Rietveld 408576698