Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Unified Diff: content/browser/download/mhtml_generation_manager.h

Issue 1947263004: Introduces a new MHTML generation parameter specifying different behvaior for cache-control headers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Work on compile. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/download/mhtml_generation_manager.h
diff --git a/content/browser/download/mhtml_generation_manager.h b/content/browser/download/mhtml_generation_manager.h
index 8a76f4f421c9136e1a4482b75bcc9d40aaed4b64..0e458782c424511372ce8ff3bb85a8fdd521a3e4 100644
--- a/content/browser/download/mhtml_generation_manager.h
+++ b/content/browser/download/mhtml_generation_manager.h
@@ -1,7 +1,6 @@
// Copyright (c) 2012 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-
#ifndef CONTENT_BROWSER_DOWNLOAD_MHTML_GENERATION_MANAGER_H_
#define CONTENT_BROWSER_DOWNLOAD_MHTML_GENERATION_MANAGER_H_
@@ -15,6 +14,7 @@
#include "base/macros.h"
#include "base/memory/singleton.h"
#include "base/process/process.h"
+#include "content/public/common/mhtml_generation.h"
#include "ipc/ipc_platform_file.h"
namespace base {
@@ -40,8 +40,7 @@ class MHTMLGenerationManager {
// Instructs the render view to generate a MHTML representation of the current
// page for |web_contents|.
void SaveMHTML(WebContents* web_contents,
- bool use_binary_encoding,
- const base::FilePath& file_path,
+ const MHTMLGenerationParams& params,
const GenerateMHTMLCallback& callback);
// Handler for FrameHostMsg_SerializeAsMHTMLResponse (a notification from the
@@ -49,7 +48,7 @@ class MHTMLGenerationManager {
void OnSerializeAsMHTMLResponse(
RenderFrameHostImpl* sender,
int job_id,
- bool mhtml_generation_in_renderer_succeeded,
+ MHTMLSerializationResult mhtml_generation_result,
const std::set<std::string>& digests_of_uris_of_serialized_resources);
private:
@@ -75,7 +74,7 @@ class MHTMLGenerationManager {
// Creates and registers a new job.
int NewJob(WebContents* web_contents,
- bool use_binary_encoding,
+ const MHTMLGenerationParams& params,
const GenerateMHTMLCallback& callback);
// Finds job by id. Returns nullptr if no job with a given id was found.

Powered by Google App Engine
This is Rietveld 408576698