content/browser/download/save_package.cc - Issue 1947263004: Introduces a new MHTML generation parameter specifying different behvaior for cache-control headers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/download/save_package.cc

Issue 1947263004: Introduces a new MHTML generation parameter specifying different behvaior for cache-control headers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Work on compile. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/download/mhtml_generation_browsertest.cc ('K') | « content/browser/download/mhtml_generation_manager.cc ('k') | content/browser/frame_host/render_frame_host_impl.h » ('j') | content/browser/frame_host/render_frame_host_impl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/download/save_package.cc

diff --git a/content/browser/download/save_package.cc b/content/browser/download/save_package.cc

index 040543dd311768c23e285cb8f7854fb5655dbc4d..a4514fd193eee3cafb75966c0965c09a75fdd8b0 100644

--- a/content/browser/download/save_package.cc

+++ b/content/browser/download/save_package.cc

@@ -26,6 +26,7 @@

#include "content/browser/download/download_item_impl.h"

#include "content/browser/download/download_manager_impl.h"

#include "content/browser/download/download_stats.h"

+#include "content/browser/download/mhtml_generation_manager.h"

Łukasz Anforowicz 2016/05/12 18:56:48 Is the new include needed? I thought that save_pa

dewittj 2016/05/12 22:58:01 Done. Yes, I went through quite a few revisions h

#include "content/browser/download/save_file.h"

#include "content/browser/download/save_file_manager.h"

#include "content/browser/download/save_item.h"

@@ -338,8 +339,9 @@ void SavePackage::InitWithDownloadItem(

DCHECK(!saved_main_directory_path_.empty());

GetSavableResourceLinks();

} else if (save_type_ == SAVE_PAGE_TYPE_AS_MHTML) {

+ MHTMLGenerationParams mhtml_generation_params(saved_main_file_path_);

web_contents()->GenerateMHTML(

- saved_main_file_path_, false /* use_binary_encoding */,

+ mhtml_generation_params,

base::Bind(&SavePackage::OnMHTMLGenerated, this));

} else {

DCHECK_EQ(SAVE_PAGE_TYPE_AS_ONLY_HTML, save_type_);