Chromium Code Reviews Chromium Code Reviews
Issue 194713009:
Make sure table cells are laid out again when fragmentainer height changes. (Closed)
Base URL: https://chromium.googlesource.com/chromium/blink.git@master| Index: LayoutTests/fast/multicol/table-cell-content-change.html |
| diff --git a/LayoutTests/fast/multicol/table-cell-content-change.html b/LayoutTests/fast/multicol/table-cell-content-change.html |
| new file mode 100644 |
| index 0000000000000000000000000000000000000000..d5920ec5b4960f32000291a8376175d1fe452356 |
| --- /dev/null |
| +++ b/LayoutTests/fast/multicol/table-cell-content-change.html |
| @@ -0,0 +1,26 @@ |
| +<!DOCTYPE html> |
| +<html> |
| + <head> |
| + <title>Changing the contents of a table cell, increasing column height</title> |
|
Julien - ping for review
2014/03/12 15:58:23
Putting anything in the title is useless from DRT'
mstensho (USE GERRIT)
2014/03/13 08:26:48
Done.
I keep thinking that my tests could be used
|
| + <script> |
| + function test() { |
| + document.body.offsetTop; // trigger layout |
| + document.getElementById('elm').style.display = 'block'; |
| + } |
| + </script> |
| + </head> |
| + <body onload="test()"> |
| + <p>You should see the text "first column" once in the first column, and the text "second |
| + column" twice in the second column.</p> |
| + <div style="-webkit-columns:2; columns:2; x-webkit-column-rule:1px solid; xcolumn-rule:1px solid; orphans:1; widows:1; xbackground:yellow;"> <!-- FIXME: should ideally paint background and column rules here, to measure the column height, but the balancing machinery in the old multicol implementation doesn't do it properly. --> |
|
Julien - ping for review
2014/03/12 15:58:23
Can we link to bugs about fixing these bits. Putti
mstensho (USE GERRIT)
2014/03/13 08:26:48
Done.
|
| + <div style="display:table-row;"> |
|
Julien - ping for review
2014/03/12 15:58:23
Nit: Space after ":". I didn't repeat this comment
mstensho (USE GERRIT)
2014/03/13 08:26:48
I really prefer no space after ':' when using styl
|
| + first column |
| + <div style="height:0.1em;"></div> |
| + </div> |
| + <div style="display:table-row;"> |
| + second column |
| + <div id="elm" style="display:none;">second column</div> |
| + </div> |
| + </div> |
| + </body> |
| +</html> |
