LayoutTests/fast/multicol/table-cell-content-change.html - Issue 194713009: Make sure table cells are laid out again when fragmentainer height changes.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/multicol/table-cell-content-change.html

Issue 194713009: Make sure table cells are laid out again when fragmentainer height changes. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Use the old multicol implementation in the tests. The new one has a bug that needs to be fixed befo… Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <title>Changing the contents of a table cell, increasing column height</ title>
	Julien - ping for review 2014/03/12 15:58:23 Putting anything in the title is useless from DRT' Putting anything in the title is useless from DRT's perspective as we don't dump it. It's better to jut dump it into the test as it's a nice description of what you are testing. mstensho (USE GERRIT) 2014/03/13 08:26:48 Done. I keep thinking that my tests could be used Show quoted text On 2014/03/12 15:58:23, Julien Chaffraix - PST wrote: > Putting anything in the title is useless from DRT's perspective as we don't dump > it. > > It's better to jut dump it into the test as it's a nice description of what you > are testing. Done. I keep thinking that my tests could be used by others than DRT, such as humans. But yeah, it still doesn't HAVE TO be in TITLE.
	5 <script>

	6 function test() {

	7 document.body.offsetTop; // trigger layout

	8 document.getElementById('elm').style.display = 'block';

	9 }

	10 </script>

	11 </head>

	12 <body onload="test()">

	13 <p>You should see the text "first column" once in the first column, and the text "second

	14 column" twice in the second column.</p>

	15 <div style="-webkit-columns:2; columns:2; x-webkit-column-rule:1px solid ; xcolumn-rule:1px solid; orphans:1; widows:1; xbackground:yellow;"> <!-- FIXME: should ideally paint background and column rules here, to measure the column he ight, but the balancing machinery in the old multicol implementation doesn't do it properly. -->
	Julien - ping for review 2014/03/12 15:58:23 Can we link to bugs about fixing these bits. Putti Can we link to bugs about fixing these bits. Putting a FIXME in a test is more or less dropping the ball. mstensho (USE GERRIT) 2014/03/13 08:26:48 Done. Show quoted text On 2014/03/12 15:58:23, Julien Chaffraix - PST wrote: > Can we link to bugs about fixing these bits. Putting a FIXME in a test is more > or less dropping the ball. Done.
	16 <div style="display:table-row;">
	Julien - ping for review 2014/03/12 15:58:23 Nit: Space after ":". I didn't repeat this comment Nit: Space after ":". I didn't repeat this comment for all colons in all the tests. mstensho (USE GERRIT) 2014/03/13 08:26:48 I really prefer no space after ':' when using styl Show quoted text On 2014/03/12 15:58:23, Julien Chaffraix - PST wrote: > Nit: Space after ":". I didn't repeat this comment for all colons in all the > tests. I really prefer no space after ':' when using style attributes. That way it's easier for the eye to see separate declarations, if you have more of them.
	17 first column

	18 <div style="height:0.1em;"></div>

	19 </div>

	20 <div style="display:table-row;">

	21 second column

	22 <div id="elm" style="display:none;">second column</div>

	23 </div>

	24 </div>

	25 </body>

	26 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/multicol/table-cell-content-change-expected.html » ('j') | Source/core/rendering/RenderBox.cpp » ('J')